CircleCI: Run some key flake8 tests (#64)

These tests find Python syntax errors and undefined names.

.circleci/config.yml

@@ -84,7 +84,7 @@ jobs:
  name: Run tests
  command: |
  . venv/bin/activate
- # flake8 --exclude=venv* --statistics
+ flake8 . --count --exclude=./venv* --select=E9,F63,F7,F82 --show-source --statistics
  coverage erase
  coverage run --source=scrapydweb -m pytest tests -s -vv -l --disable-warnings -x
 

requirements-tests.txt

@@ -1,5 +1,5 @@
 pip>=19.1.1
-# flake8
+flake8
 coverage
 pytest
 # pytest-cov

scrapydweb/views/myview.py

@@ -7,6 +7,7 @@
 from flask import flash, g, request, url_for
 from flask.views import View
 from logparser import __version__ as LOGPARSER_VERSION
+from six import text_type
 
 from ..__version__ import __version__ as SCRAPYDWEB_VERSION
 from ..common import (get_now_string, get_response_from_view, handle_metadata,
@@ -345,7 +346,7 @@ def safe_walk(self, top, topdown=True, onerror=None, followlinks=False):
 
  new_names = []
  for name in names:
- if isinstance(name, unicode):
+ if isinstance(name, text_type):
  new_names.append(name)
  else:
  msg = "Ignore non-unicode filename %s in %s" % (repr(name), top)

scrapydweb/views/operations/deploy.py

@@ -13,6 +13,7 @@
 import zipfile
 
 from flask import flash, redirect, render_template, request, url_for
+from six import text_type
 from six.moves.configparser import Error as ScrapyCfgParseError
 from werkzeug.utils import secure_filename
 
@@ -78,7 +79,7 @@ def set_scrapy_cfg_list(self):
  except UnicodeDecodeError:
  if PY2:
  for name in os.listdir(os.path.join(self.SCRAPY_PROJECTS_DIR, u'')):
- if not isinstance(name, unicode):
+ if not isinstance(name, text_type):
  msg = "Ignore non-unicode filename %s in %s" % (repr(name), self.SCRAPY_PROJECTS_DIR)
  self.logger.error(msg)
  flash(msg, self.WARN)