Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch barplot tests from ci to errorbar #2949

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

stefmolin
Copy link
Contributor

@stefmolin stefmolin commented Aug 10, 2022

I noticed that running the test_categorical.py file prints out a lot of FutureWarnings (see below for some examples), which aren't being checked for the in the tests themselves. Since the ci parameter is being deprecated in barplot() (#2866), I updated these tests to use errorbar as indicated in the FutureWarning. There were also cases of palette being provided without hue, which I addressed as well.

tests/test_categorical.py::TestBarPlotter::test_unaligned_index
  /Users/stefanie/seaborn/tests/test_categorical.py:2357: FutureWarning:

  The `ci` parameter is deprecated. Use `errorbar='sd'` for the same effect.

    cat.barplot(x=self.g, y=self.y, ci="sd", ax=ax1)

tests/test_categorical.py::TestCatPlot::test_plot_colors
  /Users/stefanie/seaborn/tests/test_categorical.py:2905: FutureWarning: Passing `palette` without assigning `hue` is deprecated.
    g = cat.catplot(x="g", y="y", data=self.df, palette="Set2")

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #2949 (18eb6fe) into master (ae9080d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2949   +/-   ##
=======================================
  Coverage   98.30%   98.31%           
=======================================
  Files          69       69           
  Lines       23004    23030   +26     
=======================================
+ Hits        22615    22641   +26     
  Misses        389      389           
Impacted Files Coverage Δ
seaborn/axisgrid.py 97.20% <100.00%> (+0.01%) ⬆️
tests/test_axisgrid.py 99.38% <100.00%> (+0.01%) ⬆️
tests/test_categorical.py 99.77% <100.00%> (ø)

@mwaskom mwaskom added this to the v0.12.0 milestone Aug 11, 2022
@mwaskom
Copy link
Owner

mwaskom commented Aug 11, 2022

Thanks @stefmolin this is super helpful

@mwaskom mwaskom merged commit 2c3ea6f into mwaskom:master Aug 11, 2022
@stefmolin stefmolin deleted the rename-ci-to-errorbar-in-tests branch August 11, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants