Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise minimal supported Python to 3.7 and bump requirements #2396

Merged
merged 8 commits into from
Dec 21, 2020
Merged

Raise minimal supported Python to 3.7 and bump requirements #2396

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7ab20a9
Raise minimal officially supported Python to 3.7
mwaskom Dec 20, 2020
ee2bddd
Make minor bumps to minimally supported library dependencies
mwaskom Dec 20, 2020
a66a8f9
Change pip requirements style in CI
mwaskom Dec 20, 2020
e6b445e
Remove code that special-cases now unsupported scipy
mwaskom Dec 21, 2020
5d20367
Fix KDE weights test
mwaskom Dec 21, 2020
4995341
Adapt test that fails on pinned matplotlib
mwaskom Dec 21, 2020
78fb1e5
Remove compatability for no-longer-supported dependency versions
mwaskom Dec 21, 2020
ed0a315
Update release notes
mwaskom Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove code that special-cases now unsupported scipy
  • Loading branch information
@mwaskom
mwaskom committed Dec 21, 2020
commit e6b445e1ce1ba29af4b6545693fc84b5180c8071
5 changes: 0 additions & 5 deletions seaborn/_statistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@
class instantiation.

"""
from distutils.version import LooseVersion
from numbers import Number
import numpy as np
import scipy as sp
from scipy import stats

from .utils import _check_argument
Expand Down Expand Up @@ -129,9 +127,6 @@ def _fit(self, fit_data, weights=None):
"""Fit the scipy kde while adding bw_adjust logic and version check."""
fit_kws = {"bw_method": self.bw_method}
if weights is not None:
if LooseVersion(sp.__version__) < "1.2.0":
msg = "Weighted KDE requires scipy >= 1.2.0"
raise RuntimeError(msg)
fit_kws["weights"] = weights

kde = stats.gaussian_kde(fit_data, **fit_kws)
Expand Down