Fix cmake warning on Multithreaded params #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So what is this pr about? |
sorry i forgot to mention in the description, basically fix the warning when build project files due wrong params set |
|
Will it work with older CMake versions? We have cmake_minimum_required(VERSION 3.1.0) currently and we don't want to bump it unless absolutely necessary. |
|
yea it should be fine, ive noticed about this on my mod back in 2021 when cmake_minimum_required(VERSION 3.0) so i checked the documentation back then and updated, i never had any problems since then. i just downloaded yesterday the jk2mv and mvsdk repos and noticed about this (using cmake 3.24.0) thats why i did the pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the params properly to prevent the next warnings when generating project files.
CMake Warning (dev) at CMakeLists.txt:218 (set): implicitly converting 'TYPE' to 'STRING' type.
CMake Warning (dev) at CMakeLists.txt:219 (set): implicitly converting 'TYPE' to 'STRING' type.