-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: README and docs update #389
Conversation
-[x] slimmed down README to remove a lot of the duplication that's already in docs -[x] added 'Audio player' Guide with a simple audio example -[x] added missing attribute docs for `audio` on Media controller -[x] added "In the wild" to Learn More section in nav to show places where Media Chrome is used in the wild -[x] added "Basics" > "Media slot" doc with details about the media slot, media element and how that works -[x] added "Media Clip Selector" under components
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is great! Could the media-clip-selector also be a live example like the other controls? the screenshot doesn't look too good |
The audio player page should also be a live example I think or have the codesandbox inline. The current link navigates users away from the docs site |
Thanks @luwes -- I split out the clip selector guide into another branch because it wasn't working quite right on the docs page. The thumbnail container was positioned incorrectly. Might be a bug with the clip selector itself, will have to dig into that one. Good call on the other improvements though, better to actually render the real web component instead of doing screenshots! @heff I put the audio example back |
This seems to 404 as well, maybe we need a rebuild? https://media-chrome-docs-git-fork-dylanjha-dj-docs-updates-mux.vercel.app/en/media-clip-selector |
audio
on Media controller