Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to AGP 8.0 #51

Merged
merged 8 commits into from
May 12, 2023
Merged

Migration to AGP 8.0 #51

merged 8 commits into from
May 12, 2023

Conversation

aditya-bhawsar-mm
Copy link
Member

  • Upgraded to AGP 8.0
  • Upgraded to kotlin version 1.7.0
  • Upgraded compose to 1.2.0
  • Upgraded Hilt to 2.42
  • Removed Hilt ViewModel dependency

@aditya-bhawsar-mm aditya-bhawsar-mm added the enhancement New feature or request label May 12, 2023
@aditya-bhawsar-mm aditya-bhawsar-mm self-assigned this May 12, 2023
shubhamsinghmutualmobile
shubhamsinghmutualmobile approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@shubhamsinghmutualmobile shubhamsinghmutualmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but could we move to even newer versions of these dependencies? For example Kotlin 1.8.21, Compose 1.4.7, Hilt 2.46, etc?

@aditya-bhawsar-mm
Copy link
Member Author

LGTM but could we move to even newer versions of these dependencies? For example Kotlin 1.8.21, Compose 1.4.7, Hilt 2.46, etc?

will do that separately since the agenda for this was to fix all the errors and warnings that come with AGP 8.0

@aditya-bhawsar-mm aditya-bhawsar-mm merged commit 6b36615 into baseproject May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsinghmutualmobile shubhamsinghmutualmobile shubhamsinghmutualmobile approved these changes

Assignees

@aditya-bhawsar-mm aditya-bhawsar-mm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aditya-bhawsar-mm @shubhamsinghmutualmobile