Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue #112 w/GCC_NO_COMMON_BLOCKS build setting #116

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Fixing issue #112 w/GCC_NO_COMMON_BLOCKS build setting #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixing issue #112. New GCC_NO_COMMON_BLOCKS setting recommended in Xc… 
…ode 6.3 breaks anything that imports MMRecordDebugging.
  • Loading branch information
Lars Anderson committed May 20, 2015
commit 4b27f590834f3e8188085e83045e1a879eb52472
2 changes: 2 additions & 0 deletions Examples/MMRecordAppDotNet/MMRecordAppDotNet.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,7 @@
55F95200165C73460060851E /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordAppDotNet/MMRecordAppDotNet-Prefix.pch";
INFOPLIST_FILE = "MMRecordAppDotNet/MMRecordAppDotNet-Info.plist";
Expand All @@ -790,6 +791,7 @@
buildSettings = {
CODE_SIGN_IDENTITY = "iPhone Distribution";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordAppDotNet/MMRecordAppDotNet-Prefix.pch";
INFOPLIST_FILE = "MMRecordAppDotNet/MMRecordAppDotNet-Info.plist";
Expand Down
1 change: 0 additions & 1 deletion Examples/MMRecordAppDotNet/MMRecordAppDotNet/ADNPostsViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ @interface ADNPostsViewController () <FBTweakViewControllerDelegate>

@property (nonatomic, strong) ADNPostManager *postManager;
@property (nonatomic, copy) NSArray *posts;
@property (nonatomic, strong) UIRefreshControl *refreshControl;

@end

Expand Down
2 changes: 2 additions & 0 deletions Examples/MMRecordAtlassian/MMRecordAtlassian.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,7 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = MMRecordAtlassian/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -427,6 +428,7 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = MMRecordAtlassian/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
2 changes: 2 additions & 0 deletions Examples/MMRecordFoursquare/MMRecordFoursquare/MMRecordFoursquare.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "";
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordFoursquare/MMRecordFoursquare-Prefix.pch";
INFOPLIST_FILE = "MMRecordFoursquare/MMRecordFoursquare-Info.plist";
Expand All @@ -715,6 +716,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;
CODE_SIGN_IDENTITY = "iPhone Distribution";
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordFoursquare/MMRecordFoursquare-Prefix.pch";
INFOPLIST_FILE = "MMRecordFoursquare/MMRecordFoursquare-Info.plist";
Expand Down
2 changes: 2 additions & 0 deletions Examples/MMRecordInstagram/MMRecordInstagram.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,7 @@
9FABD8DA16FA7DC700184BA5 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordInstagram/Source/MMRecordInstagram-Prefix.pch";
INFOPLIST_FILE = "MMRecordInstagram/SupportingFiles/MMRecordInstagram-Info.plist";
Expand All @@ -666,6 +667,7 @@
buildSettings = {
CODE_SIGN_IDENTITY = "iPhone Distribution";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordInstagram/Source/MMRecordInstagram-Prefix.pch";
INFOPLIST_FILE = "MMRecordInstagram/SupportingFiles/MMRecordInstagram-Info.plist";
Expand Down
2 changes: 2 additions & 0 deletions Examples/MMRecordPerformance/MMRecordPerformance.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,7 @@
55F95200165C73460060851E /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordAppDotNet/MMRecordPerformance-Prefix.pch";
INFOPLIST_FILE = "MMRecordAppDotNet/MMRecordPerformance-Info.plist";
Expand All @@ -666,6 +667,7 @@
buildSettings = {
CODE_SIGN_IDENTITY = "iPhone Distribution";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordAppDotNet/MMRecordPerformance-Prefix.pch";
INFOPLIST_FILE = "MMRecordAppDotNet/MMRecordPerformance-Info.plist";
Expand Down
2 changes: 2 additions & 0 deletions Examples/MMRecordTwitter/MMRecordTwitter.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,7 @@
55C6BD1C16FD5416000114DF /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordTwitter/MMRecordTwitter-Prefix.pch";
INFOPLIST_FILE = "MMRecordTwitter/MMRecordTwitter-Info.plist";
Expand All @@ -592,6 +593,7 @@
buildSettings = {
CODE_SIGN_IDENTITY = "iPhone Distribution";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "MMRecordTwitter/MMRecordTwitter-Prefix.pch";
INFOPLIST_FILE = "MMRecordTwitter/MMRecordTwitter-Info.plist";
Expand Down
2 changes: 1 addition & 1 deletion Source/MMRecord/MMRecord.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ + (NSArray *)objectIDsForRecords:(NSArray *)records

NSError *coreDataError = nil;
if ([backgroundContext save:&coreDataError] == NO) {
NSString *coreDataErrorString = [NSString stringWithFormat:@"Core Data error occurred with code: %d, description: %@",
NSString *coreDataErrorString = [NSString stringWithFormat:@"Core Data error occurred with code: %zd, description: %@",
coreDataError.code,
coreDataError.localizedDescription];
NSString *errorDescription = [NSString stringWithFormat:@"Unable to save background context while populating records. MMRecord import operation unsuccessful. %@",
Expand Down
20 changes: 10 additions & 10 deletions Source/MMRecord/MMRecordDebugger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ typedef NS_ENUM(NSInteger, MMRecordLoggingLevel) {
};

// MMRecordErrorDomain is the domain used for all errors created and returned by MMRecordDebugger
NSString * const MMRecordErrorDomain;
FOUNDATION_EXTERN NSString * const MMRecordErrorDomain;

/**
MMRecordDebuggerKey can be used to access the instance of MMRecordDebugger on
the error object's userInfo dictionary. You may want to use this to view all
errors encountered on the population process, as well as metadata about the
request itself, including the response object and initial entity.
*/
NSString * const MMRecordDebuggerKey;
FOUNDATION_EXTERN NSString * const MMRecordDebuggerKey;

/**
MMRecordDebuggerParameters are keys used to pass information along to
Expand All @@ -59,14 +59,14 @@ NSString * const MMRecordDebuggerKey;
an error's userInfo dictionary if those objects have been passed into the
handleErrorCode:withParameters: method defined below.
*/
NSString * const MMRecordDebuggerParameterErrorDescription;
NSString * const MMRecordDebuggerParameterResponseObject;
NSString * const MMRecordDebuggerParameterRecordClassName;
NSString * const MMRecordDebuggerParameterKeyPathForResponseObject;
NSString * const MMRecordDebuggerParameterEntityDescription;
NSString * const MMRecordDebuggerParameterPropertyName;
NSString * const MMRecordDebuggerParameterRecordDictionary;
NSString * const MMRecordDebuggerParameterServerClassName;
FOUNDATION_EXTERN NSString * const MMRecordDebuggerParameterErrorDescription;
FOUNDATION_EXTERN NSString * const MMRecordDebuggerParameterResponseObject;
FOUNDATION_EXTERN NSString * const MMRecordDebuggerParameterRecordClassName;
FOUNDATION_EXTERN NSString * const MMRecordDebuggerParameterKeyPathForResponseObject;
FOUNDATION_EXTERN NSString * const MMRecordDebuggerParameterEntityDescription;
FOUNDATION_EXTERN NSString * const MMRecordDebuggerParameterPropertyName;
FOUNDATION_EXTERN NSString * const MMRecordDebuggerParameterRecordDictionary;
FOUNDATION_EXTERN NSString * const MMRecordDebuggerParameterServerClassName;


/**
Expand Down