Propagate HTTP errors in AFMMRecordResponseSerializer #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFMMRecordResponseSerializer was silently swallowing all errors from the HTTPResponseSerializer and attempting to parse responses regardless. Fix by returning nil as the response object while the correct error is set.
|
I was just stepping through this last night to try to figure out why the errors weren't coming through from AFMMRecordResponseSerializer. Wish I had seen your pull request and saved myself some time. +1 for this! |
|
I had to push an unrelated commit to my fork's master, so I recreated this PR from a branch #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFMMRecordResponseSerializer was silently swallowing all errors from the
HTTPResponseSerializer and attempting to parse responses regardless.
Fix by returning nil as the response object while the correct error is set.