This repository has been archived by the owner on Sep 14, 2019. It is now read-only.
Adjust precision of feet -> meters conversion #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://en.wikipedia.org/wiki/Foot_(unit), the foot is recognized as being exactly 0.3048 meters. It isn't clear where the former conversion factor of 3.2828 came from, as it really should be 1 / 0.3048 = 3.28084. In any case, we're better off just using the official value, as we can multiply rather than divide.
|
Inspired by the change in #153, which made me double-check the other conversion here. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://en.wikipedia.org/wiki/Foot_(unit), the foot is recognized
as being exactly 0.3048 meters. It isn't clear where the former
conversion factor of 3.2828 came from, as it really should be
1 / 0.3048 = 3.28084.
In any case, we're better off just using the official value, as we can
multiply rather than divide.
For an altitude of 37,000 feet, the old code gives 11,270.9 meters, and the new code gives 11,277.6 meters. Not exactly a huge difference, but seems worth getting it right.