add an option to build the soundfont reproducibly #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. https://wiki.debian.org/ReproducibleBuilds/OggSerialNumbers
std::numeric_limits<qint64>::max()
is used as flag to keep the previous behaviour ofsrand(time(NULL));
and usingrand()
as the stream serial number, as it’s outside of the range of anint
. Otherwise, the integer argument is used directly as the stream serial number.I expect most people to use
-S 0
when converting their soundfonts.With this patch applied, with exact same options (using the new
-S
) and input, the output.sf3
file is byte-for-byte identical no matter when it is built.