Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs and build, rename to sf3convert #18

Merged
merged 7 commits into from
Mar 25, 2018

Conversation

mirabilos
Copy link
Contributor

As packaged already in Debian and/or discussed at: #12

  • Rename sfconvert to sf3convert
  • Add a manual page
  • Install the binary and manual page on nōn-MinGW
  • something like global-flags in the main MuseScore repo, in small

Interestingly enough, the Debian buildsystem still appends the necessary flags (-fPIC to override -fPIE) and -std=gnu++11 afterwards, so I don’t need to patch the flags further. I just did a test build with this patch (and the #17 spelling fixes) applied, and it WFM.

@mirabilos mirabilos changed the title Fix docs and build Fix docs and build, rename to sf3convert Mar 13, 2018
@lasconic lasconic merged commit 55902ad into musescore:master Mar 25, 2018
@mirabilos mirabilos deleted the fix-docs-and-build branch March 25, 2018 15:50
@mirabilos mirabilos restored the fix-docs-and-build branch March 25, 2018 17:30
@mirabilos mirabilos deleted the fix-docs-and-build branch March 25, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants