Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mods #4

Merged
merged 5 commits into from
Nov 28, 2016
Merged

Mods #4

merged 5 commits into from
Nov 28, 2016

Conversation

stevel05
Copy link
Contributor

Removed pluginType : "dialog" which seems to have been showing two windows on MAC, tested on an old one and no longer displays two.

Added property score to window object to record the score the plugin is working on.
Added title to window to make it obvious which score the text belongs to
Changed from Keys.onPressed to Keys.onReleased as in some circumstances the last keypress was lost.
Added onActiveChanged to window object to check if the score has changed, If it has, the text and title are changed as appropriate.

@lasconic
Copy link
Contributor

Great work. I will merge it as it.
For your next contribution in this project or others, some git etiquette. No need to add comment with your name in the code. Instead, use proper commit message describing in one line what you changed in that given commit. If some commits are related, squash them together http:https://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

@lasconic lasconic merged commit 4ade910 into musescore:master Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants