[MU3] Fix #295588: Add Petaluma font #5381

Jojo-Schmitz · 2019-10-12T15:46:04Z

As taken from https://github.com/steinbergmedia/petaluma

resolves https://musescore.org/en/node/295588

Jojo-Schmitz · 2019-10-12T18:45:19Z

Not sure we want or need Petaluma specific vtests. Or whether there are any font specific mtests.

mscore/editstyle.cpp

mscore/editstyle.ui

Jojo-Schmitz · 2019-10-13T07:19:08Z

libmscore/sym.cpp

- QFont::insertSubstitution("MuseJazz Text", "Bravura Text");
+ QFont::insertSubstitution("MuseJazz Text", "Bravura Text");
+ QFont::insertSubstitution("Petaluma Text", "Bravura Text");
+ QFont::insertSubstitution("Petaluma Script","Bravura Text");


Here Petaluma Script probably isn't needed either, see above

Jojo-Schmitz · 2019-10-13T08:15:35Z

libmscore/mscore.cpp

@@ -358,6 +358,8 @@ void MScore::init()
 ":/fonts/bravura/BravuraText.otf",
 ":/fonts/gootville/GootvilleText.otf",
 ":/fonts/mscore/MScoreText.ttf",
+ ":/fonts/petaluma/PetalumaText.otf",
+ ":/fonts/petaluma/PetalumaScript.otf",


Here Petaluma Script is needed, in the same way as FreeSerif is, Question is whether Petaluma Text is needed here?

Jojo-Schmitz · 2019-10-13T08:24:26Z

mscore/CMakeLists.txt

@@ -1071,6 +1072,8 @@ if (APPLE)
 ../fonts/mscoreTab.ttf
 ../fonts/mscore-BC.ttf
 ../fonts/bravura/BravuraText.otf
+ ../fonts/petaluma/PetalumaText.otf
+ ../fonts/petaluma/PetalumaScript.otf


Here Petaluma Script is needed, in the same way as FreeSerif is, Question is whether Petaluma Text is needed here? This might be independant of the question above.
Guess a Mac user and developer is needed here...

mscore/musescorefonts-Mac.qrc

ecstrema · 2020-02-20T12:39:43Z

It would be good to see this one merged.
Could you please add collect artifacts, so we can test it?

Jojo-Schmitz · 2020-02-20T12:42:00Z

rebased and done ;-)

ecstrema · 2020-02-20T12:58:22Z

Where do you set the style loaded when the font is chosen (when loadStyleBasedOnFont checkbox is checked)?

Jojo-Schmitz · 2020-02-20T13:17:26Z

You mean optimizeStyleCheckbox? I don't think any additional coding is needed there, scoreFont->engravingDefaults() should take care of that

ecstrema · 2020-02-20T16:39:47Z

I thought a style file was associated with each individual engraving font, and that these were loaded when a different font was specified.

Jojo-Schmitz · 2020-02-20T16:59:45Z

Not that I'd know

ecstrema · 2020-02-20T18:34:55Z

So what is this?

ecstrema · 2020-02-20T19:02:47Z

Works well!
I especially like the big keysigs and the "normal" fermatas. (compared to musejazz)

ecstrema · 2020-02-20T19:04:49Z

That was Petaluma text.
This one is Petaluma script:

ecstrema · 2020-02-20T19:05:14Z

Both are nice except for chord symbols

Jojo-Schmitz · 2020-02-21T06:39:41Z

So what is this?

That is the button optimizeStyleCheckbox triggering scoreFont->engravingDefaults() which gets some settings from the font itself, its .json file I think

ecstrema · 2020-02-21T16:56:25Z

Ah. It's clear now. I read
"load style settings based on font" as
"load style file based on font"

ecstrema · 2020-04-09T22:59:28Z

@anatoly-os any news regarding the merging of this PR?

and use Steinberg's naming to easy further updates

Jojo-Schmitz · 2020-10-19T11:33:56Z

It is in master now, waiting for it to get merged into 3.x for 3.6

Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...)

Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)

Jojo-Schmitz force-pushed the petaluma branch from b0c00cc to d4f56ed Compare October 12, 2019 17:05

Jojo-Schmitz closed this Oct 12, 2019

Jojo-Schmitz force-pushed the petaluma branch from d4f56ed to 2e7a18c Compare October 12, 2019 17:49

Jojo-Schmitz reopened this Oct 12, 2019

Jojo-Schmitz commented Oct 13, 2019

View reviewed changes

mscore/editstyle.cpp Outdated Show resolved Hide resolved

Jojo-Schmitz commented Oct 13, 2019

View reviewed changes

mscore/editstyle.ui Outdated Show resolved Hide resolved

Jojo-Schmitz commented Oct 13, 2019

View reviewed changes

mscore/musescorefonts-Mac.qrc Outdated Show resolved Hide resolved

Jojo-Schmitz force-pushed the petaluma branch from 9ed0f2a to f52dbe5 Compare December 19, 2019 16:47

Jojo-Schmitz force-pushed the petaluma branch from 1e8bef6 to b04f522 Compare February 20, 2020 12:41

Jojo-Schmitz force-pushed the petaluma branch from b04f522 to 251b8fd Compare March 12, 2020 09:23

Jojo-Schmitz mentioned this pull request Apr 17, 2020

MuseScore 3.5 Alpha PRs to be merged #5960

Closed

Jojo-Schmitz mentioned this pull request May 4, 2020

MuseScore 3.5 Beta. PRs to be merged #6027

Closed

12 tasks

Jojo-Schmitz changed the base branch from master to 3.x May 8, 2020 07:27

Jojo-Schmitz force-pushed the petaluma branch from 251b8fd to 7171393 Compare May 10, 2020 19:24

Jojo-Schmitz mentioned this pull request Jun 16, 2020

MuseScore 3.5 Release Candidate. PRs to be merged #6195

Closed

1 task

Jojo-Schmitz force-pushed the petaluma branch from 7171393 to 5063abf Compare July 6, 2020 11:58

Fix #295588: add Petaluma font + collect_artifacts

0c494e2

and use Steinberg's naming to easy further updates

Jojo-Schmitz force-pushed the petaluma branch from 5063abf to 0c494e2 Compare July 6, 2020 12:15

Jojo-Schmitz mentioned this pull request Aug 23, 2020

Porting my 3.x PRs to master #6483

Merged

30 tasks

Jojo-Schmitz changed the title ~~Fix #295588: add Petaluma font~~ [MU3] Fix #295588: Add Petaluma font Oct 20, 2020

Jojo-Schmitz mentioned this pull request Oct 21, 2020

MuseScore 3.6 Alpha. PRs to be merged and issues to be fixed. #6505

Closed

74 tasks

vpereverzev approved these changes Oct 22, 2020

View reviewed changes

vpereverzev merged commit 40b4f6d into musescore:3.x Oct 22, 2020

Jojo-Schmitz deleted the petaluma branch October 22, 2020 14:29

Jojo-Schmitz referenced this pull request in cbjeukendrup/MuseScore Aug 30, 2021

Fixed SMuFL anchors

fe3ec20

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021

Fixed SMuFL anchors

0f30502

Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MU3] Fix #295588: Add Petaluma font #5381

[MU3] Fix #295588: Add Petaluma font #5381

Jojo-Schmitz commented Oct 12, 2019 •

edited

Loading

Jojo-Schmitz commented Oct 12, 2019 •

edited

Loading

Jojo-Schmitz Oct 13, 2019 •

edited

Loading

Jojo-Schmitz Oct 13, 2019 •

edited

Loading

Jojo-Schmitz Oct 13, 2019 •

edited

Loading

ecstrema commented Feb 20, 2020

Jojo-Schmitz commented Feb 20, 2020

ecstrema commented Feb 20, 2020

Jojo-Schmitz commented Feb 20, 2020 •

edited

Loading

ecstrema commented Feb 20, 2020

Jojo-Schmitz commented Feb 20, 2020

ecstrema commented Feb 20, 2020

ecstrema commented Feb 20, 2020

ecstrema commented Feb 20, 2020

ecstrema commented Feb 20, 2020

Jojo-Schmitz commented Feb 21, 2020 •

edited

Loading

ecstrema commented Feb 21, 2020

ecstrema commented Apr 9, 2020

Jojo-Schmitz commented Oct 19, 2020

[MU3] Fix #295588: Add Petaluma font #5381

[MU3] Fix #295588: Add Petaluma font #5381

Conversation

Jojo-Schmitz commented Oct 12, 2019 • edited Loading

Jojo-Schmitz commented Oct 12, 2019 • edited Loading

Jojo-Schmitz Oct 13, 2019 • edited Loading

Choose a reason for hiding this comment

Jojo-Schmitz Oct 13, 2019 • edited Loading

Choose a reason for hiding this comment

Jojo-Schmitz Oct 13, 2019 • edited Loading

Choose a reason for hiding this comment

ecstrema commented Feb 20, 2020

Jojo-Schmitz commented Feb 20, 2020

ecstrema commented Feb 20, 2020

Jojo-Schmitz commented Feb 20, 2020 • edited Loading

ecstrema commented Feb 20, 2020

Jojo-Schmitz commented Feb 20, 2020

ecstrema commented Feb 20, 2020

ecstrema commented Feb 20, 2020

ecstrema commented Feb 20, 2020

ecstrema commented Feb 20, 2020

Jojo-Schmitz commented Feb 21, 2020 • edited Loading

ecstrema commented Feb 21, 2020

ecstrema commented Apr 9, 2020

Jojo-Schmitz commented Oct 19, 2020

Jojo-Schmitz commented Oct 12, 2019 •

edited

Loading

Jojo-Schmitz commented Oct 12, 2019 •

edited

Loading

Jojo-Schmitz Oct 13, 2019 •

edited

Loading

Jojo-Schmitz Oct 13, 2019 •

edited

Loading

Jojo-Schmitz Oct 13, 2019 •

edited

Loading

Jojo-Schmitz commented Feb 20, 2020 •

edited

Loading

Jojo-Schmitz commented Feb 21, 2020 •

edited

Loading