-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3] Fix #295588: Add Petaluma font #5381
Conversation
b0c00cc
to
d4f56ed
Compare
d4f56ed
to
2e7a18c
Compare
Not sure we want or need Petaluma specific vtests. Or whether there are any font specific mtests. |
libmscore/sym.cpp
Outdated
QFont::insertSubstitution("MuseJazz Text", "Bravura Text"); | ||
QFont::insertSubstitution("MuseJazz Text", "Bravura Text"); | ||
QFont::insertSubstitution("Petaluma Text", "Bravura Text"); | ||
QFont::insertSubstitution("Petaluma Script","Bravura Text"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here Petaluma Script probably isn't needed either, see above
@@ -358,6 +358,8 @@ void MScore::init() | |||
":/fonts/bravura/BravuraText.otf", | |||
":/fonts/gootville/GootvilleText.otf", | |||
":/fonts/mscore/MScoreText.ttf", | |||
":/fonts/petaluma/PetalumaText.otf", | |||
":/fonts/petaluma/PetalumaScript.otf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here Petaluma Script is needed, in the same way as FreeSerif is, Question is whether Petaluma Text is needed here?
mscore/CMakeLists.txt
Outdated
@@ -1071,6 +1072,8 @@ if (APPLE) | |||
../fonts/mscoreTab.ttf | |||
../fonts/mscore-BC.ttf | |||
../fonts/bravura/BravuraText.otf | |||
../fonts/petaluma/PetalumaText.otf | |||
../fonts/petaluma/PetalumaScript.otf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here Petaluma Script is needed, in the same way as FreeSerif is, Question is whether Petaluma Text is needed here? This might be independant of the question above.
Guess a Mac user and developer is needed here...
9ed0f2a
to
f52dbe5
Compare
It would be good to see this one merged. |
1e8bef6
to
b04f522
Compare
rebased and done ;-) |
Where do you set the style loaded when the font is chosen (when loadStyleBasedOnFont checkbox is checked)? |
You mean |
I thought a style file was associated with each individual engraving font, and that these were loaded when a different font was specified. |
Not that I'd know |
Both are nice except for chord symbols |
Ah. It's clear now. I read |
@anatoly-os any news regarding the merging of this PR? |
and use Steinberg's naming to easy further updates
It is in master now, waiting for it to get merged into 3.x for 3.6 |
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
As taken from https://github.com/steinbergmedia/petaluma
resolves https://musescore.org/en/node/295588