Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Edit MIDI Mapping Dialog Accessibility #23962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shubham-shinde-442
Copy link
Contributor

Resolves: #23945

Fixed Edit MIDI Mapping Dialog Accessibility.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@@ -38,6 +38,13 @@ StyledDialogView {

signal mapToEventRequested(var event)

property NavigationPanel navigationPanel: NavigationPanel {
name: "EditMidiMappingDialog"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there are extra spaces before "name"

@DmitryArefiev
Copy link
Contributor

Tested on Win/Mac

@shubham-shinde-442 Can you also add screen reading for 'waiting' field right after you add something from MIDI keyboard?
Now it works when you navigate to other buttons and then go back

bandicam.2024-08-09.17-12-56-257.mp4

@shubham-shinde-442
Copy link
Contributor Author

For this, I believe we should implement a similar approach which discussed here. @Eism, Am I heading in the right direction?

@Eism
Copy link
Contributor

Eism commented Aug 12, 2024

For this, I believe we should implement a similar approach which discussed here. @Eism, Am I heading in the right direction?

EditMidiMappingDialog is very similar to EditShortcutDialog, I see that this problem is solved for shortcuts. I think, you should look at how it is done and apply the same approach for MIDI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility issue MIDI remode control window
3 participants