Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organ pedal marks #23504

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Organ pedal marks #23504

wants to merge 5 commits into from

Conversation

PetJer
Copy link

@PetJer PetJer commented Jul 8, 2024

This is a PR for organ pedal marks.

  • Organ palette with symbols
  • Popup
  • Input mode
pedal-marks-drop pedal-marks-input-mode pedal-marks-keyboard-input

Known issues:

  • Selecting a note and applying a pedal mark from the palette opens popup in wrong position
  • "Side-of-foot" not having the right offset (because it doesn't collide with the note beam)
  • Layout doesn't work on other voices than voice 1
  • Wrong accessibility name

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Add ability to change mark from popup
Set default input position to below staff
Comment on lines +2313 to +2314
|| e->isDynamic()
|| e->isExpression()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mike-spa may want to check these two additions :)


muse::TranslatableString OrganPedalMark::typeUserName() const
{
return TranslatableString("engraving/sym", SymNames::translatedUserNameForSymId(symId()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be changed to be more in accordance with PR #20850 (see especially Articulation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants