Fix spacing glitches caused by anchors #23315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Jun 21, 2024
mike-spa
force-pushed
the
fixSpacingGlitchesCausedByAnchors
branch
from
e981f4d
to
55a620f
Compare
bkunda
approved these changes
Jun 21, 2024
oktophonie
added
vtests
RomanPudashkin
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that anchors are completely invisible for the horizontal spacing system, by making sure that TimeTick segments are always skipped/ignored where relevant. Anchors should be touched only after we know all the spacing.
Resolves:
