Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Cloud icon for cloud scores in the file menu for non-macOS platf… #23308

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

nasehim7
Copy link
Contributor

Resolves: #18014 (For non-Mac OS)

For more information, refer this discussion thread (archived PR): #21802

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup
Copy link
Contributor

@jessjwilliamson This PR should solve the linked issue, but for now only on Windows and Linux, so it would be great if you could test it on one of these OSs. For macOS, it turns out to be (much) more difficult to fix, and it would be a lower priority because we generally don't use icons at all in menus on macOS, so we postponed that; perhaps it will still happen someday in the future.

@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved

@cbjeukendrup cbjeukendrup merged commit 8e3b4f2 into musescore:master Jul 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud scores don't have labels (marks) in File > Open recent dropdown
3 participants