Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translatable plugins descriptions #23279

Closed
wants to merge 1 commit into from

Conversation

Gootector
Copy link
Contributor

@Gootector Gootector commented Jun 17, 2024

Translatable plugins descriptions

Greetings,
Gootector

Resolves: #NNNNN

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Translatable descriptions

Greetings,
Gootector
@Gootector Gootector changed the title Translatable descriptions Translatable plugins descriptions Jun 17, 2024
@cbjeukendrup
Copy link
Contributor

Unfortunately, this has no result at the moment because plugins are not yet scanned for translatable strings. But in the future, that will be fixed, so let's leave this PR open until then. Thanks!

@shoogle shoogle marked this pull request as draft June 18, 2024 01:59
@Gootector
Copy link
Contributor Author

OK.

@igorkorsukov
Copy link
Contributor

This approach allows to translate only built-in plugins (if we add a folder with plugins for scanning). But it does not allow to translate external plugins. I believe that there should be a unified localization system for built-in and external plugins. We will do it later.

@Gootector Gootector marked this pull request as ready for review July 11, 2024 17:39
@Gootector
Copy link
Contributor Author

Please merge my PR into the master.

@cbjeukendrup
Copy link
Contributor

I think this PR unfortunately won't work anymore, because of the new limited way of parsing plugins in 4.4. @igorkorsukov Is that right?

@igorkorsukov
Copy link
Contributor

yes, that's right, but as far as I understand, it wouldn't have worked before, because we don't collect strings from plugins and don't send them to transifex

@Gootector Gootector closed this by deleting the head repository Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants