Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16227 - MusicXML export is incorrect when using local timsig #23255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented Jun 15, 2024

Resolves: #16227

Changes:

  • export all time signatures for multi-staff parts

  • when streched correct duration of:

    • normal rest
    • measure rest
    • backup Note that import also requires fixes
  • I signed the CLA

  • The title of the PR describes the problem it addresses

  • Each commit's message describes its purpose and effects, and references the issue it resolves

  • If changes are extensive, there is a sequence of easily reviewable commits

  • The code in the PR follows the coding rules

  • There are no unnecessary changes

  • The code compiles and runs on my machine, preferably after each commit individually

  • I created a unit test or vtest to verify the changes I made (if applicable)

…ime signature

- export all time signatures for multi-staff parts
- when streched correct duration of:
  - normal rest
  - measure rest
  - backup
Note that import also requires fixes
@lvinken lvinken force-pushed the issues_16227_local_time_sig branch from 7fda26e to 6b4a8c5 Compare June 15, 2024 14:44
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 15, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 15, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 15, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 15, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 21, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 21, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MU4 Issue] MusicXML export is incorrect when using local time signature
1 participant