Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19104 - draft solution for tie playback with voltas #23204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wizofaus
Copy link
Contributor

Resolves: #19104

This is not intended to be an ideal solution, but would like feedback before continuining

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@wizofaus wizofaus force-pushed the fix_tie_over_volta_playback branch from 4aa4461 to 04fa5db Compare June 12, 2024 02:54
if (positionTickOffset > 0) { // this is for a repeat
auto chord = next->chord();
auto intervals = score()->spannerMap().findOverlapping(next->tick().ticks(), (next->tick() + chord->actualTicks()).ticks());
// find start of first volta
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I had hoped to be able to find a specific volta based on which repeat this was being queried for. But in fact currently it's irrelevant, it's really only notes tied into the 1st volta that are issue - there is no way of tying notes into other voltas. Basically, if you're playing a repeat, it has to assume that ties to notes in the 1st volta should be ignored.

Really the proper solution for that would allow actually creating multiple ties from the start note to notes in the various voltas, but that's a much bigger change.

@wizofaus wizofaus force-pushed the fix_tie_over_volta_playback branch from 04fa5db to c63e52f Compare June 12, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TIED NOTES] Tied notes from first volta continues to be sustained in the second volta
1 participant