Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for relative tempo markings when tempo text is added from palette #23180

Closed
wants to merge 3 commits into from

Conversation

sejudav20
Copy link

@sejudav20 sejudav20 commented Jun 11, 2024

Resolves: #15655

Metric modulations taken from the palette contain the default values for tempo, isRelative, and m_relative parameters even though they were initialized when the palette is created. Toggling the "Follow written tempo" or editing the text calls updateTempo which updates these parameters based on the text. I couldn't find why modulations from the palette went to the default parameters but for now, this work around will check the text whether the tempo indicated is relative when the tempo is added from the palette.

  • [x ] I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@oktophonie oktophonie changed the title Fix #15655: Add check for relative tempo markings when tempo text is … Add check for relative tempo markings when tempo text is added from palette Jun 11, 2024
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jun 11, 2024

The failing 3 unit tests chould easily get fixed (i.e. adjusted), but at least the 2 for MusicXML seem to indicate/uncover yet another bug, with 'normal' tempo texts (i.e. non-metric modulations, threse 2 clearly imported wrongly before your change, with a BPM of 320 rather than 80, also cortrected after toggling 'follow text') not having been recognized correctly.
So I'm not 100% convinced your change really fixes the root cause of either issue. Also, as 3 Mu3 has the same isssue, your change doesn't apply to Mu3 code at all, another hint that this might not be the right place?

@sejudav20 sejudav20 closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric modulation markings don't respect previous tempo
2 participants