-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure gap rests correspond to the <location>
gap duration
#22931
base: master
Are you sure you want to change the base?
Conversation
* Fixes some rounding errors when importing tuplets
To give a little more background to the PR. When deleting rests when there is more than one voice, a |
Sorry, I missed these. I'll have a look. |
3fc8170
to
b5f9928
Compare
I'm not 100% sure about those VTests. This looks like it's not just a rounding error. It might mean that gap rests can somehow affect horizontal spacing, which is of course not desirable, but also wouldn't be in scope of this PR to fix, in my opinion. Anyway, let's wait for a more official comment from the Engraving team. |
* The removed block was creating a rest not necessarily corresponding to the gap, yield issues in the MEI exporter
b5f9928
to
16c943a
Compare
I don't understand the reason for this change. What issue is it solving? If it isn't solving any specific issue, I would prefer it to stay as it is, because |
Transpose keysigs in parts after changing instrument
(PS as it stands, MuseScore inserts a dotted half note rest for the |
New dynamics properties for voicing and stave positioning
…layback_fix FIx musescore#21244: Ensure all tracks are updated when a caesura is edited
Fix musescore#23015 - crash adding key signature
Fixed profiler clear
MusicXML: Add support for part-name-display
fix musescore#19949: MEI tempo at measure start
MusicXML: set all note components invisible
MEI: make measure repeat symbol explicit
feat: add import/export of rehearsal marks to MEI support
…mization solo_mute_optimization
* The removed block was creating a rest not necessarily corresponding to the gap, yield issues in the MEI exporter
…al/musescore into develop-fix-fill-gaps
Gap rests have been known in the past to cause a lot of problems (score corruptions, most prominently), so forgive me if I am extremely hesitant to change anything related to them, especially now as we're entering a stabilization phase. In general, my impression has always been that gap rests are a horrible hack to work around the limitations of our representation model, so I'd prefer to work out a comprehensive solution to improve the model (and if possible get rid of them entirely) rather than keep working with them. @lpugin I do see the merit of the change you're proposing, and it may indeed be a good thing to do until we have a better solution to replace them. We'll come back to this after the release. |
@mike-spa thank you for the feedback. I understand the need to be careful with this since score corruption is very annoying. I think the proposed change remains very minimal and should make things more consistent, which I would expect to be helpful. But of course, no problem for waiting until after the release. |
Make sure that filling gaps uses only rest with valid DurationType. This means sometimes adding more than one rest (still flagged as
gap
). Adjust the MEI exporter accordingly.