note_input_optimizations #22791
Merged
note_input_optimizations #22791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c38039b
to
3c5074a
Compare
1e95283
to
bcbfd98
Compare
993a233
to
166e25a
Compare
9e809cb
to
d43bacf
Compare
2ff65ff
to
a110b97
Compare
58edcea
to
eda029a
Compare
1. fixed crash when using <= 512 buf and VST FX 2. optimized flushBuffers() 3. don't recreate in/out buffers too often 4. don't call setupProcess every time a note is entered
…d small buffer (512) In this case, WASAPI forcibly starts using a larger buffer, and we don't reserve enough samples
(don't skip any events accidentally)
Since we can have thousands of events on large scores
We used to call it 3 times in a row when entering a note
fcf42f3
to
ba00f3e
Compare
Eism
approved these changes
Jul 29, 2024
|
I'm happy for this to be merged in its current state as it will enable broader testing and easier build management, and will unblock the creation of the 4.4 branch. |
|
Tested on Win10, Mac13.6, LinuxUbuntu22.04 - PASS |
4 tasks
RomanPudashkin
added a commit
to RomanPudashkin/MuseScore
that referenced
this pull request
Jul 31, 2024
4 tasks
RomanPudashkin
added a commit
to RomanPudashkin/MuseScore
that referenced
this pull request
Sep 3, 2024
…ynth) After PR musescore#22791, we started to process all sequences in the same buffer (one process call) and use sampleOffset to separate events. However, it turns out that most plugins completely ignore sampleOffset for the params queue (IParamValueQueue), and just use the last added one. So now we won't rely on the offset and just process the sequences in different process calls
RomanPudashkin
added a commit
to RomanPudashkin/MuseScore
that referenced
this pull request
Sep 6, 2024
…ynth) After PR musescore#22791, we started to process all sequences in the same buffer (one process call) and use sampleOffset to separate events. However, it turns out that most plugins completely ignore sampleOffset for the params queue (IParamValueQueue), and just use the last added one. So now we won't rely on the offset and just process the sequences in different process calls
RomanPudashkin
added a commit
to RomanPudashkin/MuseScore
that referenced
this pull request
Sep 6, 2024
…ynth) After PR musescore#22791, we started to process all sequences in the same buffer (one process call) and use sampleOffset to separate events. However, it turns out that most plugins completely ignore sampleOffset for the params queue (IParamValueQueue), and just use the last added one. So now we won't rely on the offset and just process the sequences in different process calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #16112
Resolves: #21520
Resolves: #22639
Resolves: #12701
Muse Sounds note: to hear the difference, you need MuseSampler 0.100, which hasn't been publically released yet but will be with MuseScore Studio 4.4