Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #19575 allow removing key signature in mmrest mode #19665

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Oct 10, 2023

Resolves: #19575

KeySig, yoummee!

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup cbjeukendrup merged commit bb935e7 into musescore:master Oct 12, 2023
11 checks passed
@sammik sammik deleted the mmrest-delete-keysig branch October 12, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't remove key signature in mmRest mode
3 participants