Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: years without spaces #19284

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Fix: years without spaces #19284

merged 4 commits into from
Sep 6, 2023

Conversation

Gootector
Copy link
Contributor

Years without spaces - like "Copyright © 1999-2023 MuseScore BVBA and others." in the AboutDialog.qml (/src/appshell/qml/AboutDialog.qml).

Greetings,
Gootector

Resolves: #NNNNN

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Years without spaces - like "Copyright © 1999-2023 MuseScore BVBA and others." in the AboutDialog.qml (/src/appshell/qml/AboutDialog.qml).

Greetings,
Gootector
Grzegorz Pruchniakowski added 3 commits September 5, 2023 02:06
Fix: years without spaces
Fix: years without spaces
Fix: years without spaces
Years without spaces - like "Copyright © 1999-2023 MuseScore BVBA and others." in the AboutDialog.qml (/src/appshell/qml/AboutDialog.qml).

Greetings,
Gootector
@Gootector
Copy link
Contributor Author

Please squash all my commits and merge into the master. Thanks.

Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cbjeukendrup
Copy link
Contributor

The failed check is probably because the branch of this PR is not up-to-date with other changes that have been made on the master branch in the meantime, but it doesn't matter. There is no way that this change can cause problems :)

@cbjeukendrup cbjeukendrup merged commit cfd582b into musescore:master Sep 6, 2023
10 of 11 checks passed
@Gootector Gootector deleted the patch-1 branch September 6, 2023 23:36
igorkorsukov pushed a commit to igorkorsukov/MuseScore that referenced this pull request Sep 8, 2023
Years without spaces - like "Copyright © 1999-2023 MuseScore BVBA and others." in the AboutDialog.qml (/src/appshell/qml/AboutDialog.qml).

Greetings,
Gootector
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants