Fix #291847 and GH#17428: Irregular measure not marked when followed by start repeat barline #17429
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 1, 2023
… by start repeat barline Backport of musescore#17429
|
Hmm, for an end/start repeat barline it'd write that irregular marking twice. |
Jojo-Schmitz
changed the title
|
It's even a bit more confusing when a start repeat barline is preceded by a system break: There's probably a way to find out if the previous measure has an end barline (in which case we shouldn't show the sign on the start barline of the next measure). Maybe check if |
|
Check it where exactly and how? I tried out all sorts of combinations but none worked |
Jojo-Schmitz
force-pushed
the
irregular-measures-start-repeat-barline
branch
2 times, most recently
from
1df9e17
to
db6cdda
Compare
|
I got the first issue solved, but not the second, the one with start repesat barlines after a system break |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 30, 2023
… by start repeat barline Backport of musescore#17429
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 23, 2023
… by start repeat barline Backport of musescore#17429
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 2, 2023
… by start repeat barline Backport of musescore#17429
igorkorsukov
force-pushed
the
master
branch
6 times, most recently
from
fa1f8d3
to
525a11a
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 10, 2024
… by start repeat barline Backport of musescore#17429
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 11, 2024
… by start repeat barline Backport of musescore#17429
|
Hopelessly outdated |
Jojo-Schmitz
force-pushed
the
irregular-measures-start-repeat-barline
branch
from
db6cdda
to
f99c5d2
Compare
|
Rebased |
Jojo-Schmitz
force-pushed
the
irregular-measures-start-repeat-barline
branch
2 times, most recently
from
09bd955
to
5dc8ffd
Compare
… by start repeat barline
Jojo-Schmitz
force-pushed
the
irregular-measures-start-repeat-barline
branch
from
5dc8ffd
to
fc6854b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #17428 and https://musescore.org/en/node/291847
Same issue and fix in/for Mu3