Solution for hyphen-related issue #16314

[jaanusnurmoja]

Resolves: #16314
Regular hyphen key didn't work as expected with non-english keyboard when writing lyrics. With Num+- added, the regular - key works as well.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[Jojo-Schmitz]

It seems "NumPad -" is already in use for flat, so won't these collide?
See

MuseScore/src/framework/shortcuts/data/shortcuts.xml

Lines 325 to 329 in cb98f9f

	<SC>
	<key>flat</key>
	<seq>-</seq>
	<seq>Num+-</seq>
	</SC>

Edit: I take that back, they are used in different contexts and so do not collide. Looks fine by me.
It is not just a workaround IMHO, but just needed for consistency.

[jaanusnurmoja]

they are used in different contexts and so do not collide. Looks fine by me. It is not just a workaround IMHO, but just needed for consistency.

Thanks, indeed :) So pls, merge the PR, whoever will do it

[Eism]

@jaanusnurmoja did you sign CLA?
and please squash all commits into one and give that a meaningfull commit title

@shoogle FYI

[jaanusnurmoja]

@jaanusnurmoja did you sign CLA? and please squash all commits into one and give that a meaningfull commit title

@shoogle FYI

Done

[shoogle]

@jaanusnurmoja, I can't find your signature on the CLA. You need to visit https://musescore.org/en/cla to sign. If you've already done this, please tell me what your username is on MuseScore.org. Thanks!

[Jojo-Schmitz]

I don't believe that for such a trivial one-line change in some text file signing the CLA is a strict requirement.

[jaanusnurmoja]

jaanus.nurmoja N, 11. mai 2023 21:23 Peter Jonas ***@***.***> kirjutas:

…

@jaanusnurmoja <https://github.com/jaanusnurmoja>, I can't find your signature on the CLA. You need to visit https://musescore.org/en/cla to sign. If you've already done this, please tell me what your username is on MuseScore.org. Thanks! — Reply to this email directly, view it on GitHub <#17230 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIV3B6NIPGWGPZCGL5QSODXFUVDFANCNFSM6AAAAAAW4UYW6Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jaanusnurmoja]

I think so as well. But signed it anyway. At least submitted The form 🙂 R, 12. mai 2023 12:08 Joachim Schmitz ***@***.***> kirjutas:

…

I don't believe that for such a trivial one-line change in some text file signing the CLA is a requirement. — Reply to this email directly, view it on GitHub <#17230 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIV3B647W3FM7L226SVUGDXFX4XZANCNFSM6AAAAAAW4UYW6Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Jojo-Schmitz]

Thanks, it doesn't really hurt 😉

[shoogle]

@jaanusnurmoja, thanks!

I don't believe that for such a trivial one-line change in some text file signing the CLA is a strict requirement.

It's not a legal requirement for trivial changes like this, but it makes life a lot easier for us if we insist on it at the contributor's first PR rather than waiting for something non-trivial. It's only the first PR where the user gets flagged by GitHub as a "first time contributor". For later PRs there is no flag so we might miss the fact that the user hadn't signed previously.