Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style support to display capo chords only #16542

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hoongern
Copy link

Feature proposal: Add a new style option to "display capo chords only". When enabled, chord readability and layout improves (on scores with a dense number of chords), for parts/musicians which only care about the capo chords.

E.g. When enabled with capo fret 1, "Am7/C" would be displayed instead of "Bbm7/Db (Am7/C)".

Given the desired flexibility for some parts to display capo chords, other parts to display both original & capo chords, and to be synced, it seemed easier to write this into the core harmony code rather than using a plugin (although I do not have experience with the codebase and am open to other suggestions on how to achieve this effect). This does seem to mean that saving the score in a build missing the style id erases the option.

If this approach seems reasonable, I could look into writing a test (I couldn't find documentation on running unit tests on Mac OS). I've performed a simple manual test with a mix of chord symbols, nashville chords and roman numerals.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@bkunda bkunda added the feature request Used to suggest improvements or new capabilities label Jul 10, 2023
@cbjeukendrup cbjeukendrup added the guitar Related to guitar notation and user experience for guitarists label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Used to suggest improvements or new capabilities guitar Related to guitar notation and user experience for guitarists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants