Add style support to display capo chords only #16542
Open
+25
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature proposal: Add a new style option to "display capo chords only". When enabled, chord readability and layout improves (on scores with a dense number of chords), for parts/musicians which only care about the capo chords.
E.g. When enabled with capo fret 1, "Am7/C" would be displayed instead of "Bbm7/Db (Am7/C)".
Given the desired flexibility for some parts to display capo chords, other parts to display both original & capo chords, and to be synced, it seemed easier to write this into the core harmony code rather than using a plugin (although I do not have experience with the codebase and am open to other suggestions on how to achieve this effect). This does seem to mean that saving the score in a build missing the style id erases the option.
If this approach seems reasonable, I could look into writing a test (I couldn't find documentation on running unit tests on Mac OS). I've performed a simple manual test with a mix of chord symbols, nashville chords and roman numerals.