Fix for Issue #16219: [MU4 Issue] Customise note input toolbar popup points to empty space

[octopols]

Resolves: #16219

Customise note input toolbar popup now points to the settings cog when the toolbar is set vertical.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[octopols]

issue_16226_fix.mp4

[cbjeukendrup]

This fix looks a bit naive to me. If you resize the MuseScore window to a smaller vertical size, then the bug will probably be back.

I think a real solution would be to move the arrow to the left side of the popup, in this case. That's a bit more complicated though.

[octopols]

I was just checking how the popup behaves with different screen sizes, having a fixed height even to 2 numbers like in this fix will cause some issues (look at the screenshot attached). I'll try to write a function which takes the application size as a parameter and changed the height accordingly.
When the toolbar is vertical I think you're right the best solution is to just put the arrow on the side of the popup.

[DmitryArefiev]

@octopols @cbjeukendrup Hi! Is this ready for testing?

[octopols]

@octopols @cbjeukendrup Hi! Is this ready for testing?

Sorry for the late reply but this fix does not completely solves the problem. I'm trying to work on the solution Casper suggested and I hope it doesn't take that long to implement.

[DmitryArefiev]

Good. Thanks!