Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit note input mode when changing navigation, fixing mouse panning bug on publish screen #15352

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

randoguyname
Copy link
Contributor

Fixing bug where unable to pan across publish page with mouse when switched to page while in note input mode.

Resolves: #15277

Disable note input mode when switching from notation tab, fixing bug where the user is unable to pan across the score in the publish tab due to still being in that mode.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@Eism
Copy link
Contributor

Eism commented Jan 9, 2023

@randoguyname
I think we can fix the bug like this:

if (!isPrinting) {
    m_noteInputCursor->paint(painter);
}

It is in AbstractNotationPaintView::paint.
We shouldn't draw the note input cursor for printing(publish) mode

@MarcSabatella
Copy link
Contributor

Drag of notes and text in normal mode is also enabled in Publish when it presumably should not be, so that also needs to be addressed, either as part of this same change or a separate one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants