Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #14349: added togglable round tempo MIDI #15115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue #14349: added togglable round tempo MIDI #15115

wants to merge 1 commit into from
+75 −2

Conversation

shachiang428
Copy link

@shachiang428 shachiang428 commented Dec 12, 2022 •
edited by cbjeukendrup
Loading

Resolves: #14349

Some users may find it frustrating that when importing MIDI files automatically rounds tempos to integers. This feature addition allows users to toggle the round tempo option as a solution to this issue.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

cbjeukendrup
cbjeukendrup reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good already; only a few very small remarks!

src/appshell/qml/Preferences/internal/MidiSection.qml Outdated Show resolved Hide resolved
src/appshell/view/preferences/importpreferencesmodel.h Show resolved Hide resolved
src/importexport/midi/internal/midiimport/importmidi_tempo.cpp Outdated Show resolved Hide resolved
@Giddii
Fix issue musescore#14349: added togglable round tempo MIDI
c9a501d 
Some users may find it frustrating that when importing MIDI files
automatically rounds tempos to integers. This feature addition allows
users to toggle the round tempo option as a solution to this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup left review comments

@RomanPudashkin RomanPudashkin Awaiting requested review from RomanPudashkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Musescore 4 MIDI Import rounds tempo changes to integers
3 participants
@shachiang428 @cbjeukendrup @Giddii