Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palette shortcuts #12850

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from
Draft

Conversation

VanSHOE
Copy link
Contributor

@VanSHOE VanSHOE commented Aug 14, 2022

This is a proof-of-concept Pull Request containing all the work done on palette shortcuts done up till now.
After discussion with @shoogle, we found some issues that would require to be solved before this system can be implemented.
I mentioned these issues in GSoC'22 Week 8 blogpost.
This particular feature spans months of work hence there might be some useless pieces of code that I will clean up.

Currently you can assign shortcuts to palette items from the palette sidebar or from preferences.
The shortcuts are stored in the workspace where other palette cell data is stored.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@VanSHOE VanSHOE changed the title Palette shortcuts draft Palette shortcuts Aug 14, 2022
We need to open the dialogue box of editing cell to initiate lambda, so that needs to be centralized.
Conflict handling not working well
Havent yet tested editing multiple shortcuts from the list
@cbjeukendrup cbjeukendrup added the GSoC PRs created by GSoC participants during coding period label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC PRs created by GSoC participants during coding period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants