-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4 Issue] Lyrics have too much vertical spacing between verses and hyphens too high #8615
Comments
wizofaus
pushed a commit
to wizofaus/MuseScore
that referenced
this issue
Jul 16, 2021
…g of lyrics inc. hyphens
8 tasks
I wonder whether this is related to all lyrics being seen as even one, due to a bug, see #8762 (review) and #7627 |
igorkorsukov
pushed a commit
that referenced
this issue
Aug 4, 2021
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The vertical gap between verses of lyrics is far too great, and hyphens between words are rendered too high (almost top aligned)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Same as MU3.6
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
This is seems to be due to the global "FontPaintDevice" that is passed into QFontMetricsF in qfontprovider.cpp for lineSpacing() and xHeight(). If no device is passed in to QFontMetricsF , the values are returned as per MU3.6 and the alignment looks correct.
But I'm not sure what the reasoning behind having this device is, and why it would make sense for some functions but not others.
Update: I believe the correct fix is to actually not multiply any info that comes back from fontMetrics by MScore::pixelRatio, which is what happens currently with both lineSpacing() and xHeight() (in textbase.cpp and lyricsline.cpp)
The text was updated successfully, but these errors were encountered: