Crash When creating Linked Part in Master

[Gai-Luron]

Issue type

Crash or freeze

Bug description

Crash When creating Linked Part in Master : OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.4.0-241750505, revision: github-musescore-musescore-6ddd3a6

Steps to reproduce

1 - Create a score with different part.
2 - Create a linked part
3 -Crash

Screenshots/Screen recordings

2024-06-23.Crash.MuseScore.mp4

MuseScore Version

MuseScore Studio version (64-bit): 4.4.0-241750505, revision: github-musescore-musescore-6ddd3a6

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

OS: Windows 10 Version 2009 or later, Arch.: x86_64,

Additional context

WOrk in previous version : OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.4.0-241730506, revision: github-musescore-musescore-1c28ffe

[cbjeukendrup]

This turns out to have been caused by #23320. This is what I wrote to @Eism about it this morning:
The problem is in DockPanelView::DockPanelMenuModel. I think that what happens is the following:

1. m_customMenuModel wants to update its items
2. it deletes its old ones and sets new ones
3. That triggers DockPanelView::DockPanelMenuModel to set new items.
4. DockPanelView::DockPanelMenuModel deletes the old items that it contains. Among these old items are the old items from m_customMenuModel. These had already been deleted, so now we’re trying to delete them again.