Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add a missing instrument name #21662

Closed
tpgettys opened this issue Feb 23, 2024 · 17 comments · Fixed by #23808
Closed

Request to add a missing instrument name #21662

tpgettys opened this issue Feb 23, 2024 · 17 comments · Fixed by #23808
Assignees
Labels
feature request Used to suggest improvements or new capabilities instruments Issues relating to instrument definitions

Comments

@tpgettys
Copy link

Your idea

I have created a score, and wish to change an instrument, so I double-click the instrument name, and am presented with a dialog titled "Staff/Part properties". Under "Part properties" there is a button titled "Replace instrument...". When I click that, at the top-left is button titled "Family".

After I select the Early Music family, I see "Treble Viol", "Alto Viol" and "Tenor Viol", but inexplicably, there is no "Bass Viol". Instead, there is a "Viola da Gamba". There are four sizes of Viola da Gamba, Treble, Alto, Tenor and Bass. Please change "Viola da Gamba" to say "Bass Viol".

Problem to be solved

There is an instrument missing from the family of Viola da Gamba, specifically the Bass Viol

Prior art

No response

Additional context

No response

@muse-bot muse-bot added the feature request Used to suggest improvements or new capabilities label Feb 23, 2024
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 25, 2024

Rather add a "Bass Viol", keeping "Viola da Gamba" as the generic type?

@tpgettys
Copy link
Author

tpgettys commented Feb 25, 2024

I have no problem with that. The most important thing is to add a "Bass Viol" to the list.

On the one hand, keeping Viola da Gamba as well may create uncertainly in the user's mind (what does that mean? What is the distinction between it and the others?) In the recorder family there are 8 'flavors' offered in MuseScore. Should we then add a generic "Recorder" for that group as well?

On the other hand, when one says 'The Viola da Gamba' they almost certainly mean a bass viol. Likewise, when someone says 'The Recorder' they almost certainly mean the Alto Recorder.

Bottom line: whatever you decide is fine with me, as long as the Bass Viol is added.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 26, 2024

Seems there were a generic instruments in 3.x, like a plain Recorder (to mean the Soprano Recorder!), similar for Trumpet (to mean Trumpet in Bb), but there isn't anymore in 4.x?

@tpgettys
Copy link
Author

I can see the value of having a generic instrument, especially for a transposing instrument like the trumpet. Bb makes sense for a "Trumpet". Likewise Bass Viol for "Viola da Gamba", and Alto Recorder for "Recorder" (the alto plays at pitch, whereas the soprano plays an octave higher than written).

@oktophonie oktophonie added the instruments Issues relating to instrument definitions label Feb 27, 2024
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 27, 2024

Ahh! Aparently I confused that due to their German names, Soprano Recoder -> C-Flöte, Alto Recorder -> F-Flöte, but that's just their lowest pitch, not their transpositioning. Still Recorder is Soprano Recorder in Mu3 (as Blockflöte is C-Flöte in German)

@MarcSabatella
Copy link
Contributor

I disagree that most people associate the generic term "recorder" with alto. The soprano is by far more common, at least in the US. Every school child learns to play one as part of the regular curriculum. Pretty much everyone in the US is familiar with soprano recorder and knows it simply as "recorder", and few even know that other recorders exist.

It may of course be different in other countries, or within the field of early music specialists.

@Jojo-Schmitz
Copy link
Contributor

As mentioned, same in Germany

@oktophonie
Copy link
Contributor

'Generic' instruments were removed because they were literally duplicates of a more specific instrument with a different name, so they were needless clutter in the definitions file.

What might be nice is a way to define alternative names (aliases) for instruments, so that you can find them (and add them to the score) with different names.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 27, 2024

Something like

            <Instrument id="recorder-generic">
                  <init>soprano-recorder</init>
                  <family>recorders</family>
                  <trackName>Recorder</trackName>
                  <longName>Recorder</longName>
                  <description>Soprano or descant. Pitched in C.</description>
                  <genre>common</genre>
                  <genre>classroom</genre>
            </Instrument>

That'd take away a good part of the redundant/duplicate information, and so eases the maintainance.

BTW, soprano recorder currently is in <genre>earlymusic</genre> in in that only, that seems very wrong. Same for Alto recorder, often the 2nd instrument pupils learn after the soprano.

There also is

            <Instrument id="recorder">
                  <family>recorders</family>
                  <description>Soprano or descant recorder, pitched in C.</description>
                  <musicXMLid>wind.flutes.recorder</musicXMLid>
                  <clef>G8va</clef>
                  <barlineSpan>1</barlineSpan>
                  <aPitchRange>72-93</aPitchRange>
                  <pPitchRange>72-98</pPitchRange>
                  <Channel>
                        <!--MIDI: Bank 0, Prog 74; MS General: Recorder-->
                        <program value="74"/> <!--Recorder-->
                  </Channel>
                  <genre>common</genre>
                  <genre>classroom</genre>
            </Instrument>

But that is is lacking track-, long- and short name?!?! And so not offered at all. Seems e remnant of the former 'generic' one

@Jojo-Schmitz
Copy link
Contributor

For the topic at hand here:

            <Instrument id="bass-viol">
                  <init>viola-da-gamba</init>
                  <family>viols</family>
                  <trackName>Bass viol</trackName>
                  <longName>Bass viol</longName>
                  <shortName>B. Vl.</shortName>
                  <description>Bass viol, also known as Viola da gamba.</description>
                  <genre>earlymusic</genre>
            </Instrument>

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 27, 2024

See my draft/sample PR #21719, something to discuss?

@Jojo-Schmitz
Copy link
Contributor

Similar issue for Flageolett, Ocarina and probably many many more

@shoogle
Copy link
Contributor

shoogle commented Feb 27, 2024

@Jojo-Schmitz, your solution would work except it assigns a different ID to each alias, which is something we want to avoid. The viola da gamba has a tablature and a non-tablature version, so if you create a tablature and non-tablature version of the bass viol as well then you would have 4 versions of the same instrument.

Instead, we want the IDs to represent physical instruments. Within an instrument, you would be able to specify different aliases and notational variants.

In the XML, it might look something like this:

            <Instrument id="viola-da-gamba">
                  <family>viols</family>
                  <genre>earlymusic</genre>
                  <description>Bass viol, also known as Viola da gamba.</description>
                  <alias>
                        <trackName>Viola da gamba</trackName>
                        <longName>Viola da gamba</longName>
                        <shortName>Vla. d. g.</shortName>
                  </alias>
                  <alias>
                        <trackName>Bass viol</trackName>
                        <longName>Bass viol</longName>
                        <shortName>B. Vl.</shortName>
                  </alias>
                  <notation>
                        <staffType>standard</staffType>=
                  </notation>
                  <notation>
                        <staffType>tablature</staffType>=
                  </notation>
            </Instrument>

However, this is not a concrete proposal. It requires more research to determine which properties need to be specified within the notational variants, and how all this information would be presented to the user in the New Score dialog.

For example, we might decide that certain notational variants should only be available for certain aliases, in which case the XML structure I've shown above wouldn't work.

@Jojo-Schmitz
Copy link
Contributor

That <init> method might not be the best, but has the extra benefit that it works out of the box and now

@tpgettys
Copy link
Author

tpgettys commented Feb 27, 2024

My reading of the above comment by oktophonie is that there are no longer any generic instruments. Since someone is addressing this request to add the Bass Viol they might want to also add "Soprano recorder" to the "Classroom" family. Right now there is only a tin whistle in the woodwinds.

@shoogle
Copy link
Contributor

shoogle commented May 27, 2024

After I select the Early Music family, I see "Treble Viol", "Alto Viol" and "Tenor Viol", but inexplicably, there is no "Bass Viol". [...] Please change "Viola da Gamba" to say "Bass Viol".

@oktophonie, are you happy with this change?

@shoogle

This comment was marked as resolved.

@musescore musescore deleted a comment from tpgettys May 29, 2024
shoogle added a commit to shoogle/MuseScore that referenced this issue Jul 29, 2024
@shoogle shoogle closed this as completed in 8205b11 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Used to suggest improvements or new capabilities instruments Issues relating to instrument definitions
Projects
None yet
6 participants