-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home key or fn+left arrow do not move screen to start of score when a slur/tie is selected #20146
Comments
The source code indicates that some special behaviour is intended when pressing the home key for slurs: MuseScore/src/engraving/dom/slur.cpp Lines 134 to 141 in 5384a15
That looks like it is intended to reset the position of the currently selected grip, if any. |
Happy to make this change if it's agreed what the new behaviour should be - I did a fair bit of work on this a few years back, so it's even possible something I introduced. Does 3.6 have the same problem? |
3.6 works correctly. I would suggest just returning that behaviour (i.e. Home key always just scrolls to start). We can then decide on a new, more logical, shortcut for the "reset current handle" functionality. I would propose the @bkunda Agree? |
There is quite a lot of code to support the Home key as a special case, even this:
which seems odd...but it strikes me that this behaviour should only occur in edit mode (much as I'd like to get rid of edit mode, we're stuck with it for now...). And the code suggests it should only kick in when a particular grip is selected... |
Ok I just retested and Home works fine when a slur is selected. Only behaves differently if you select a specific grip - but: Maybe initially reported issue is Mac-specific? In which case I can't really help sorry... |
I don't think it's Mac-specific. The behaviour I'm seeing is similar to what you describe:
|
The "off" property for at least some of the handles doesn't seem to ever be used. I would think it would be quite useful to request a specific handle to be reset to its default position, but I'm not sure how feasible that is - it's not clear the information is even stored in a way that makes that possible. However I just observe something weird where it appeared to work providing I also used Home on another handle too. Hmm, weird though, now I am able to reproduce the behaviour initially described even though no grip handle is shown as selected - and I can see how to fix that much at least. |
Think I might have figured it out with the middle grip handle - you have to reset the offsets of the two either side. So with my fix the new behaviour is: However...I also noticed that UNDO doesn't work properly when using Home key like this (it's not done via an undoable action). |
Fixed Undo too. And Ties. However "home" still does nothing if the "drag" grip - which controls the overall relative position of the whole item on the score - is selected. |
It is a Mu3 regression |
Issue type
UX/Interaction bug (incorrect behaviour)
Bug description
When a slur/tie is selected, the end or fn+right arrow takes the focus to the end of the score as expected, but home or fn+left arrow does not go to the beginnning of the score
Steps to reproduce
Screenshots/Screen recordings
video1119601149.mp4
MuseScore Version
OS: macOS 14.1, Arch.: x86_64, MuseScore version (64-bit): 4.2.0-233260301, revision: github-musescore-musescore-acb1bad
Regression
No.
Operating system
All
Additional context
Until recently this actually caused a crash, that was fixed, but the actual functionality still needs to be fixed.
The text was updated successfully, but these errors were encountered: