Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tremolo stem direction does not update in Properties panel when tremolos are flipped with keyboard shortcut #18312

Open
oktophonie opened this issue Jun 30, 2023 · 2 comments · May be fixed by #23126
Open

Tremolo stem direction does not update in Properties panel when tremolos are flipped with keyboard shortcut #18312

oktophonie opened this issue Jun 30, 2023 · 2 comments · May be fixed by #23126
Assignees
@wizofaus
Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation)

Comments

@oktophonie
Copy link
Contributor

oktophonie commented Jun 30, 2023 •
edited
Loading

(Spun off from #18259; thanks to @LupusCaeruleus for the original)

Issue type

UI bug

Bug description

Unlike independent notes, pressing X to flip the tremolo beam will not update the state of the Stem direction buttons in the properties panel. The buttons will only update after the user de-select and re-select the tremolo notes.

Steps to reproduce

  1. Select a tremolo beam, press X for multiple times.
  2. See the Stem direction buttons in the properties panel.

Screenshots/Screen recordings

248565924-808ec850-563c-46a4-893a-98dbca63fc3b.mp4

MuseScore Version

4.1.0

Regression

No.

Operating system

Windows 10, Linux
@oktophonie oktophonie added the P3 Priority: Low label Jun 30, 2023
@muse-bot muse-bot added the UI Visual issues affecting the UI (not notation) label Jun 30, 2023
@oktophonie oktophonie mentioned this issue Jun 30, 2023
Closed
@wizofaus
Copy link
Contributor

wizofaus commented Jun 3, 2024

Looks like a simple fix, happy to put my hand up for it.

@cbjeukendrup
Copy link
Contributor

@wizofaus That would be great! Shouldn't be too complicated indeed, see for example StemSettingsModel::onNotationChanged for inspiration

@cbjeukendrup cbjeukendrup assigned wizofaus and unassigned Eism Jun 3, 2024
wizofaus added a commit to wizofaus/MuseScore that referenced this issue Jun 7, 2024
@wizofaus
Fix musescore#18312 - ensure stem direction is updated correctly in t…
e824c13 
…remolo properties pane
@wizofaus wizofaus linked a pull request Jun 7, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wizofaus wizofaus

Labels
P3 Priority: Low UI Visual issues affecting the UI (not notation)
Projects
MuseScore Studio 4.4
Status: In progress
Milestone
No milestone
5 participants
@wizofaus @Eism @muse-bot @oktophonie @cbjeukendrup