Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Musescore 4 MIDI Import rounds tempo changes to integers #14349

Open
vsthem opened this issue Nov 5, 2022 · 5 comments · May be fixed by #15115
Open

Musescore 4 MIDI Import rounds tempo changes to integers #14349

vsthem opened this issue Nov 5, 2022 · 5 comments · May be fixed by #15115
Assignees
@shachiang428
Labels
community Issues we would like the community to address good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute

Comments

@vsthem
Copy link

vsthem commented Nov 5, 2022

MuseScoreNightly-223090408-master-2c34155-x86_64

Import the MIDI File with Tempo changes that include decimal places, ex: 90.55BPM

Current behavior: Takes tempo changes and rounds them to integers

Expected behavior: Import Tempo Changes with decimal places without rounding them to the nearest integer

Attempting to use JACK and Ardour to sync Musescore to audio that was not recorded to a click, and later tempo mapped. For the sync to work, Musescore must be able to import more exact tempo changes.
@cbjeukendrup
Copy link
Contributor

I think we should make this configurable. Not all users will like to see a "quarter note = 90.55" marking on their score...
A "round tempo" checkbox in Preferences > Import > MIDI (on by default) would be nice.

This seems to be a good first issue for new contributors (or maybe a good second issue). As a starting point, see the following things:

  • importmidi_tempo.cpp
  • the IMidiImportExportConfiguration class (and where it is used)
  • MidiSection.qml for the Preferences GUI
  • the ImportPreferencesModel class for the import preferences model

@cbjeukendrup cbjeukendrup added good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute community Issues we would like the community to address labels Nov 5, 2022
@shachiang428
Copy link

Can I be assigned to this issue? This would be my first contribution.

@cbjeukendrup
Copy link
Contributor

@shachiang428 Yes, you're welcome to work on this!

@shachiang428
Copy link

@vsthem do you perhaps have the MIDI file in question and can you upload it to this issue?

@vsthem
Copy link
Author

vsthem commented Dec 12, 2022

midi_export_0.zip
wouldn't let me upload a midi so I zipped it. Should have a tempo of 66.889 at Measure 33

shachiang428 pushed a commit to shachiang428/MuseScore that referenced this issue Dec 12, 2022
@Giddii
Fix issue musescore#14349: added togglable round tempo MIDI
484140c 
Some users may find it frustrating that when importing MIDI files
automatically rounds tempos to integers. This feature addition allows
users to toggle the round tempo option as a solution to this issue.
@shachiang428 shachiang428 linked a pull request Dec 12, 2022 that will close this issue
Open
8 tasks
shachiang428 pushed a commit to shachiang428/MuseScore that referenced this issue Dec 12, 2022
@Giddii
Fix issue musescore#14349: added togglable round tempo MIDI
994fc82 
Some users may find it frustrating that when importing MIDI files
automatically rounds tempos to integers. This feature addition allows
users to toggle the round tempo option as a solution to this issue.
shachiang428 pushed a commit to shachiang428/MuseScore that referenced this issue Dec 12, 2022
@Giddii
Fix issue musescore#14349: added togglable round tempo MIDI
c85edf8 
Some users may find it frustrating that when importing MIDI files
automatically rounds tempos to integers. This feature addition allows
users to toggle the round tempo option as a solution to this issue.
shachiang428 pushed a commit to shachiang428/MuseScore that referenced this issue Dec 13, 2022
@Giddii
Fix issue musescore#14349: added togglable round tempo MIDI
96bcc6b 
Some users may find it frustrating that when importing MIDI files
automatically rounds tempos to integers. This feature addition allows
users to toggle the round tempo option as a solution to this issue.
shachiang428 pushed a commit to shachiang428/MuseScore that referenced this issue Dec 13, 2022
@Giddii
Fix issue musescore#14349: added togglable round tempo MIDI
c9a501d 
Some users may find it frustrating that when importing MIDI files
automatically rounds tempos to integers. This feature addition allows
users to toggle the round tempo option as a solution to this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shachiang428 shachiang428

Labels
community Issues we would like the community to address good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute
Projects
Community Projects
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #14349: added togglable round tempo MIDI shachiang428/MuseScore
3 participants
@cbjeukendrup @shachiang428 @vsthem