Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU4 Issue] Dock panels have no minimum size (especially problematic when they are undocked) #10019

Open
cbjeukendrup opened this issue Dec 8, 2021 · 2 comments · May be fixed by #22136
Open

[MU4 Issue] Dock panels have no minimum size (especially problematic when they are undocked) #10019

cbjeukendrup opened this issue Dec 8, 2021 · 2 comments · May be fixed by #22136
Assignees
@Eism @cbjeukendrup
Labels
community Issues particularly suitable for community contributors to work on good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P2 Priority: Medium UI Visual issues affecting the UI (not notation)
Projects
4.x SHORTLIST

Comments

@cbjeukendrup
Copy link
Contributor

cbjeukendrup commented Dec 8, 2021 •
edited
Loading

Describe the bug
"Vertical" dockable panels (Palettes, Instruments, etc.) have no minimum height. This is not very noticeable when they are docked, but becomes a real problem when they are floating.

Similarly, horizontal panels (Mixer, etc.) have no minimum width.

Bye.bye.palettes.mov

See also #15676 (comment), which also mentions some work-arounds.

Proposed solution
I would suggest setting a minimum height of 200 pixels, for all four vertical panels. All panels become scrollable if their content is taller than themselves, so it really doesn't need to be much. With a height of 200, they are still usable (not very comfortable, but users with a small screen may have no choice).
For the horizontal panels, I would suggest a minimum width of 300 px.

Hint: See NotationPage.qml.
@RomanPudashkin RomanPudashkin added community Issues particularly suitable for community contributors to work on good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute labels Dec 13, 2021
@RomanPudashkin RomanPudashkin added this to To do in [MU4.0 - GENERAL] via automation Dec 13, 2021
@cbjeukendrup cbjeukendrup changed the title [MU4 Issue] Dock panels have no minimum height (especially problematic when they are undocked) [Good first issue] [MU4 Issue] Dock panels have no minimum height (especially problematic when they are undocked) Dec 13, 2021
@cbjeukendrup cbjeukendrup mentioned this issue Dec 13, 2021
Closed
@VaibhavAher219

This comment was marked as outdated.

Sign in to view
patrickmartinasin added a commit to patrickmartinasin/MuseScore that referenced this issue Jan 4, 2022
@patrickmartinasin
Fix musescore#10019: set min height/width for dock panels
173f4a3
@patrickmartinasin patrickmartinasin mentioned this issue Jan 4, 2022
Closed
8 tasks
@RomanPudashkin RomanPudashkin added this to Needs triage in [MU4.0 ALPHA2] via automation Mar 26, 2022
@RomanPudashkin RomanPudashkin added the P2 Priority: Medium label Mar 26, 2022
@vpereverzev vpereverzev moved this from Needs triage to In progress in [MU4.0 ALPHA2] Apr 8, 2022
@Tantacrul
Copy link
Contributor

Tantacrul commented May 27, 2022 •
edited
Loading

@cbjeukendrup - agreed. I'm assigning you.

I've also added a comment on #10207 to see if we can get that merged.

patrickmartinasin added a commit to patrickmartinasin/MuseScore that referenced this issue Jun 1, 2022
@patrickmartinasin
Fix musescore#10019: set min height/width for dock panels
f9f5525
@Tantacrul Tantacrul removed this from In progress in [MU4.0 ALPHA2] Jul 13, 2022
@Tantacrul Tantacrul added this to Needs triage in [MU4.0 BETA1] via automation Jul 13, 2022
@vpereverzev vpereverzev moved this from Needs triage to Low priority in [MU4.0 BETA1] Aug 29, 2022
@Tantacrul Tantacrul removed this from Low priority in [MU4.0 BETA1] Sep 12, 2022
@Tantacrul Tantacrul added this to To do in 4.x SHORTLIST via automation Sep 12, 2022
@oktophonie oktophonie added the UI Visual issues affecting the UI (not notation) label Jul 28, 2023
@oktophonie oktophonie removed this from To do in [MU4.0 - GENERAL] Jul 28, 2023
@oktophonie oktophonie moved this from To do to In progress in 4.x SHORTLIST Jul 28, 2023
@cbjeukendrup cbjeukendrup changed the title [MU4 Issue] Dock panels have no minimum height (especially problematic when they are undocked) [MU4 Issue] Dock panels have no minimum size (especially problematic when they are undocked) Sep 7, 2023
This was referenced Sep 7, 2023
Closed
Open
lllll03 pushed a commit to lllll03/MuseScore that referenced this issue Apr 1, 2024
Fix musescore#10019: add min height and width for dock panels
5398ec5
@lllll03 lllll03 linked a pull request Apr 1, 2024 that will close this issue
Open
8 tasks
lllll03 pushed a commit to lllll03/MuseScore that referenced this issue May 28, 2024
Fix musescore#10019: add max width for mixer panel
dad47ac
lllll03 added a commit to lllll03/MuseScore that referenced this issue Jun 6, 2024
@lllll03
Merge branch 'musescore:master' into fix-musescore#10019
8985363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eism Eism

@cbjeukendrup cbjeukendrup

Labels
community Issues particularly suitable for community contributors to work on good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P2 Priority: Medium UI Visual issues affecting the UI (not notation)
Projects
Community Projects
Status: In progress
MuseScore Studio Backlog
Status: Already in progress
4.x SHORTLIST
  
In progress
Milestone
No milestone
6 participants
@Eism @oktophonie @Tantacrul @cbjeukendrup @RomanPudashkin @VaibhavAher219