[DataGrid] Fix RangeError when using flex columns
#9554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9554--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
cherniavskii
commented
Jul 3, 2023
| @@ -122,9 +122,9 @@ export function useGridDimensions( | |||
| }; | |||
|
|
|||
| const scrollInformation = hasScroll({ | |||
| content: { width: columnsTotalWidth, height: rowsMeta.currentPageTotalHeight }, | |||
| content: { width: Math.round(columnsTotalWidth), height: rowsMeta.currentPageTotalHeight }, | |||
There was a problem hiding this comment.
In #9516 I didn't anticipate the floating point precision error 😅
Rather than removing Math.round, it would make more sense to use it on both sides of the equation (content width and container width)
MBilalShafi
approved these changes
Jul 4, 2023
1 task
RangeError when flex columns have duplicated field propertyRangeError when using flex columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9550
Before: https://codesandbox.io/s/quiet-frost-3yn7ss
After: https://codesandbox.io/s/stoic-cherry-6nfdz7
Fixes #9516 (comment)
Before: https://codesandbox.io/s/maximum-call-stack-size-exceeded-zhz6dw
After: https://codesandbox.io/s/maximum-call-stack-size-exceeded-forked-wwvd53