Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix react 17 editing bug #9530

Merged
merged 8 commits into from
Jul 3, 2023
Merged

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Jun 30, 2023

@romgrk romgrk added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Jun 30, 2023
@mui-bot
Copy link

mui-bot commented Jun 30, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9530--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 313 565.9 426.5 419.12 94.154
Sort 100k rows ms 544.4 1,188.7 544.4 842.28 235.133
Select 100k rows ms 201.2 306.9 223.4 238.48 38.357
Deselect 100k rows ms 138 360.6 228.7 232.58 83.224

Generated by 🚫 dangerJS against cc86e3d

@romgrk romgrk enabled auto-merge (squash) July 3, 2023 04:04
@romgrk romgrk merged commit f202915 into mui:master Jul 3, 2023
15 checks passed
@romgrk romgrk deleted the fix-react-17-editing branch July 3, 2023 07:24
@AnastasiaEvgenia
Copy link

Closes #9475

Before: https://codesandbox.io/s/blissful-scooby-t38hvj After: https://codesandbox.io/s/reverent-microservice-wr4264

Hi @romgrk ,
After upgrading to 6.9.1 this bug still persists.
In your 'after' codesandbox demo, I changed your import to 6.9.1 and it still doesn't work, but with your import of https://pkg.csb.dev/mui/mui-x/commit/364a7e5b/@mui/x-data-grid-pro it works fine.
Should I assume that there will be a version upgrade 6.9.2 version upgrade later? Could you give as a timeline of when to expect the correction to be published?

Thank you.

@romgrk
Copy link
Contributor Author

romgrk commented Jul 3, 2023

We publish at the end of each week. This has been merged hours ago, so it's not available yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGridPro] Error when editing with react 17
5 participants