Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove "product" markdown header #9517

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 28, 2023

A quick fix related to mui/material-ui#37729, AFAIK, these header product properties have no logic associated with them, it's noise, we rely on the URL. I have only added them on the migration pages where we can't be URL based, and where a change in the docs-infra could make these headers valuable to improve the Algolia search UX

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jun 28, 2023
@oliviertassinari oliviertassinari changed the title [docs] Remove product [docs] Remove "product" markdown header Jun 28, 2023
@mui-bot
Copy link

mui-bot commented Jun 28, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9517--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 482.6 938.2 808.2 707.22 184.585
Sort 100k rows ms 520.7 1,211.8 520.7 899.02 235.313
Select 100k rows ms 149.3 327.9 220 235.64 59.058
Deselect 100k rows ms 156.3 237.9 193.7 188.96 29.872

Generated by 🚫 dangerJS against d6d1b6b

@@ -1,6 +1,7 @@
---
product: charts
title: Charts - Overview
title: React Chart components
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will see how high we can rank, I have added us in https://app.ahrefs.com/rank-tracker/overview/2944028.

@oliviertassinari oliviertassinari merged commit 37f71f1 into mui:master Jun 30, 2023
@oliviertassinari oliviertassinari deleted the fix-productId branch June 30, 2023 11:57
m4theushw added a commit to m4theushw/mui-x that referenced this pull request Jun 30, 2023
oliviertassinari added a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants