Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add missing upcoming flag without issue #9449

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 24, 2023

We have two waiting for upvotes warnings in the docs without corresponding GitHub issue: https://mui.com/x/react-data-grid/column-groups/#manage-group-visibility. This leads to developers asking questions like https://mui.zendesk.com/agent/tickets/9359. We now link #6651 and #9448.

Instead, let's link them all, I have used the opportunity to normalize the message.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation linked in docs The issue is linked in the docs, so completely skew the upvotes labels Jun 24, 2023
@oliviertassinari oliviertassinari marked this pull request as ready for review June 24, 2023 12:31
@mui-bot
Copy link

mui-bot commented Jun 24, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9449--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 573.7 829.2 702 693.76 103.624
Sort 100k rows ms 803 1,107.3 1,107.3 971.32 127.079
Select 100k rows ms 216.1 351 262.6 263.8 48.363
Deselect 100k rows ms 147.1 408.3 300.6 270.06 95.944

Generated by 🚫 dangerJS against c47f2c4

Copy link
Contributor

@richbustos richbustos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joserodolfofreitas joserodolfofreitas merged commit 50f9125 into mui:master Jun 28, 2023
@oliviertassinari oliviertassinari deleted the upvote-issues branch June 28, 2023 16:34
Comment on lines +10 to +16
:::warning
This feature isn't implemented yet. It's coming.

👍 Upvote [issue #7924](https://github.com/mui/mui-x/issues/7924) if you want to see it land faster.

Don't hesitate to leave a comment on the same issue to influence what gets built. Especially if you already have a use case for this component, or if you are facing a pain point with your current solution.
:::
Copy link
Member Author

@oliviertassinari oliviertassinari Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexfauquette @samuelsycamore I think that we could migrate all the uses of <blockquotes> in our docs when it comes to callouts. In the spirit of HTML, > is meant to be a quote: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote. We usually don't need to quote anything, so either we make look like a warning callout, or maybe we don't even ever need it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree :::warning is more relevant than >. For me except in blog article I don't see usage of >

Copy link
Member

@samuelsycamore samuelsycamore Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we could migrate all the uses of in our docs when it comes to callouts.

I could've sworn I actually did this late last year but I must have lost track of the PR in the X repo at some point. 😅

Ah yep, never got merged and then was forgotten about around end-of-year holidays: #7127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation linked in docs The issue is linked in the docs, so completely skew the upvotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants