[pickers] Add referenceDate prop on TimeClock, DigitalClock and MultiSectionDigitalClock
#9356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9356--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
…ectionDigitalClock
flaviendelangle
force-pushed
the
time-reference-date
branch
from
b37c45b
to
01ea2b4
Compare
flaviendelangle
commented
Jun 20, 2023
| type TDate = any; | ||
|
|
||
| interface ViewHandler<TView> { | ||
| setViewValue: (utils: MuiPickersAdapter<any>, viewValue: TDate, view?: TView) => void; |
There was a problem hiding this comment.
I'm creating an object because I'd like to add other methods like getViewValue (or assertViewValue depending on the abstraction we want).
LukasTy
approved these changes
Jun 27, 2023
packages/x-date-pickers/src/internals/hooks/usePicker/usePickerValue.types.ts
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/MultiSectionDigitalClock/tests/MultiSectionDigitalClock.test.tsx
Show resolved
Hide resolved
flaviendelangle
changed the title
referenceDate prop on TimeClock, DigitalClock and MultiSectionDigitalClock WIPreferenceDate prop on TimeClock, DigitalClock and MultiSectionDigitalClock
flaviendelangle
force-pushed
the
time-reference-date
branch
from
7620ba7
to
d4570bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #9260
I also created a small new abstraction for view interaction in the tests because they are super hard to read and I think some consistent API would make testing a lot easier.
Next steps