lint

.eslintrc.js

@@ -71,17 +71,6 @@ module.exports = {
  rules: {
  ...baseline.rules,
  'import/prefer-default-export': 'off',
- '@typescript-eslint/no-unused-vars': [
- 'error',
- {
- vars: 'all',
- args: 'after-used',
- ignoreRestSiblings: true,
- argsIgnorePattern: '^_',
- varsIgnorePattern: '^_',
- caughtErrorsIgnorePattern: '^_',
- },
- ],
  // TODO move rule into the main repo once it has upgraded
  '@typescript-eslint/return-await': 'off',
  'no-restricted-imports': 'off',

packages/grid/x-data-grid/src/colDef/gridBooleanOperators.ts

@@ -13,7 +13,7 @@ export const getGridBooleanOperators = (): GridFilterOperator<any, boolean | nul
  }
 
  const valueAsBoolean = filterItem.value === 'true';
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return Boolean(value) === valueAsBoolean;
  };
  },

packages/grid/x-data-grid/src/colDef/gridDateOperators.ts

@@ -23,7 +23,7 @@ function buildApplyFilterFn(
 
  const time = new Date(year, month - 1, day, hour || 0, minute || 0).getTime();
 
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  if (!value) {
  return false;
  }
@@ -102,7 +102,7 @@ export const getGridDateOperators = (showTime?: boolean): GridFilterOperator<any
  {
  value: 'isEmpty',
  getApplyFilterFnV7: () => {
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value == null;
  };
  },
@@ -111,7 +111,7 @@ export const getGridDateOperators = (showTime?: boolean): GridFilterOperator<any
  {
  value: 'isNotEmpty',
  getApplyFilterFnV7: () => {
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value != null;
  };
  },

packages/grid/x-data-grid/src/colDef/gridNumericOperators.ts

@@ -17,7 +17,7 @@ export const getGridNumericQuickFilterFn = (value: any): GridApplyQuickFilterV7
  return null;
  }
 
- return (columnValue, _, __, ___): boolean => {
+ return (columnValue): boolean => {
  return parseNumericValue(columnValue) === parseNumericValue(value);
  };
 };
@@ -31,7 +31,7 @@ export const getGridNumericOperators = (): GridFilterOperator<any, number | stri
  return null;
  }
 
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return parseNumericValue(value) === filterItem.value;
  };
  },
@@ -45,7 +45,7 @@ export const getGridNumericOperators = (): GridFilterOperator<any, number | stri
  return null;
  }
 
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return parseNumericValue(value) !== filterItem.value;
  };
  },
@@ -59,7 +59,7 @@ export const getGridNumericOperators = (): GridFilterOperator<any, number | stri
  return null;
  }
 
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  if (value == null) {
  return false;
  }
@@ -77,7 +77,7 @@ export const getGridNumericOperators = (): GridFilterOperator<any, number | stri
  return null;
  }
 
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  if (value == null) {
  return false;
  }
@@ -95,7 +95,7 @@ export const getGridNumericOperators = (): GridFilterOperator<any, number | stri
  return null;
  }
 
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  if (value == null) {
  return false;
  }
@@ -113,7 +113,7 @@ export const getGridNumericOperators = (): GridFilterOperator<any, number | stri
  return null;
  }
 
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  if (value == null) {
  return false;
  }
@@ -127,7 +127,7 @@ export const getGridNumericOperators = (): GridFilterOperator<any, number | stri
  {
  value: 'isEmpty',
  getApplyFilterFnV7: () => {
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value == null;
  };
  },
@@ -136,7 +136,7 @@ export const getGridNumericOperators = (): GridFilterOperator<any, number | stri
  {
  value: 'isNotEmpty',
  getApplyFilterFnV7: () => {
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value != null;
  };
  },
@@ -149,7 +149,7 @@ export const getGridNumericOperators = (): GridFilterOperator<any, number | stri
  return null;
  }
 
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value != null && filterItem.value.includes(Number(value));
  };
  },

packages/grid/x-data-grid/src/colDef/gridSingleSelectOperators.ts

@@ -19,8 +19,7 @@ export const getGridSingleSelectOperators = (): GridFilterOperator[] =>
  if (filterItem.value == null || filterItem.value === '') {
  return null;
  }
- return (value, _, __, ___): boolean =>
- parseObjectValue(value) === parseObjectValue(filterItem.value);
+ return (value): boolean => parseObjectValue(value) === parseObjectValue(filterItem.value);
  },
  InputComponent: GridFilterInputSingleSelect,
  },
@@ -30,8 +29,7 @@ export const getGridSingleSelectOperators = (): GridFilterOperator[] =>
  if (filterItem.value == null || filterItem.value === '') {
  return null;
  }
- return (value, _, __, ___): boolean =>
- parseObjectValue(value) !== parseObjectValue(filterItem.value);
+ return (value): boolean => parseObjectValue(value) !== parseObjectValue(filterItem.value);
  },
  InputComponent: GridFilterInputSingleSelect,
  },
@@ -42,7 +40,7 @@ export const getGridSingleSelectOperators = (): GridFilterOperator[] =>
  return null;
  }
  const filterItemValues = filterItem.value.map(parseObjectValue);
- return (value, _, __, ___): boolean => filterItemValues.includes(parseObjectValue(value));
+ return (value): boolean => filterItemValues.includes(parseObjectValue(value));
  },
  InputComponent: GridFilterInputMultipleSingleSelect,
  },

packages/grid/x-data-grid/src/colDef/gridStringOperators.ts

@@ -30,7 +30,7 @@ export const getGridStringOperators = (
  const filterItemValue = disableTrim ? filterItem.value : filterItem.value.trim();
 
  const filterRegex = new RegExp(escapeRegExp(filterItemValue), 'i');
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value != null ? filterRegex.test(String(value)) : false;
  };
  },
@@ -45,7 +45,7 @@ export const getGridStringOperators = (
  const filterItemValue = disableTrim ? filterItem.value : filterItem.value.trim();
 
  const collator = new Intl.Collator(undefined, { sensitivity: 'base', usage: 'search' });
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value != null ? collator.compare(filterItemValue, value.toString()) === 0 : false;
  };
  },
@@ -60,7 +60,7 @@ export const getGridStringOperators = (
  const filterItemValue = disableTrim ? filterItem.value : filterItem.value.trim();
 
  const filterRegex = new RegExp(`^${escapeRegExp(filterItemValue)}.*$`, 'i');
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value != null ? filterRegex.test(value.toString()) : false;
  };
  },
@@ -75,7 +75,7 @@ export const getGridStringOperators = (
  const filterItemValue = disableTrim ? filterItem.value : filterItem.value.trim();
 
  const filterRegex = new RegExp(`.*${escapeRegExp(filterItemValue)}$`, 'i');
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value != null ? filterRegex.test(value.toString()) : false;
  };
  },
@@ -84,7 +84,7 @@ export const getGridStringOperators = (
  {
  value: 'isEmpty',
  getApplyFilterFnV7: () => {
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value === '' || value == null;
  };
  },
@@ -93,7 +93,7 @@ export const getGridStringOperators = (
  {
  value: 'isNotEmpty',
  getApplyFilterFnV7: () => {
- return (value, _, __, ___): boolean => {
+ return (value): boolean => {
  return value !== '' && value != null;
  };
  },
@@ -110,7 +110,7 @@ export const getGridStringOperators = (
  : filterItem.value.map((val) => val.trim());
  const collator = new Intl.Collator(undefined, { sensitivity: 'base', usage: 'search' });
 
- return (value, _, __, ___): boolean =>
+ return (value): boolean =>
  value != null
  ? filterItemValue.some((filterValue: GridFilterItem['value']) => {
  return collator.compare(filterValue, value.toString() || '') === 0;