Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add Joy UI menus slots #8991

Open
wants to merge 6 commits into
base: v6.x
Choose a base branch
from
Open

[DataGrid] Add Joy UI menus slots #8991

wants to merge 6 commits into from
+386 −203

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented May 15, 2023 •
edited
Loading

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! design: joy This is about Joy Design, please involve a visual or UX designer in the process labels May 15, 2023
@mui-bot
Copy link

mui-bot commented May 15, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8991--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 549.1 877.4 651.3 710.9 137.612
Sort 100k rows ms 484.5 1,052.9 484.5 839.58 206.947
Select 100k rows ms 160.8 303.4 275.4 244.96 55.62
Deselect 100k rows ms 186.2 332.6 211.9 229.48 52.467

Generated by 🚫 dangerJS against a4ba74e

@cherniavskii cherniavskii marked this pull request as ready for review May 17, 2023 11:36
siriwatknp
siriwatknp approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Nice!

siriwatknp
siriwatknp reviewed Jun 20, 2023
View reviewed changes
packages/grid/x-data-grid/src/joy/joySlots.tsx
baseMenu: Menu,
baseMenuItem: JoyMenuItem,
baseListItemIcon: JoyListItemDecorator,
baseListItemText: React.Fragment,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be ListItemContent

Suggested change
baseListItemText: React.Fragment,
import ListItemContent from '@mui/joy/ListItemContent';
...
baseListItemText: ListItemContent,

siriwatknp
siriwatknp requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I found a duplicate ul in the actions column.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 26, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MBilalShafi MBilalShafi changed the base branch from master to v6.x March 21, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! design: joy This is about Joy Design, please involve a visual or UX designer in the process PR: out-of-date The pull request has merge conflicts and can't be merged v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cherniavskii @mui-bot @siriwatknp @MBilalShafi