Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Draft support for js-joda #8438

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

joshkel
Copy link
Contributor

@joshkel joshkel commented Mar 29, 2023

Fixes #6470 / #4703

This also includes dmtrKovalenko/date-io#634.

If this basic approach seems desirable (if you're still interested in supporting js-joda, if you're willing to include workarounds for apparent date-io issues, etc.), then I can clean this up by adding tests and revisiting locale support.

@mui-bot
Copy link

mui-bot commented Mar 29, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8438--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 672.2 1,142.9 719 870.14 176.597
Sort 100k rows ms 704.5 1,413.9 1,413.9 1,116.16 266.395
Select 100k rows ms 294.7 362 315.3 321.02 22.202
Deselect 100k rows ms 186.5 313.6 252.6 251.62 42.47

Generated by 🚫 dangerJS against b335fbc

@zannager zannager added the component: pickers This is the name of the generic UI component, not the React module! label Mar 30, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 7, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@flaviendelangle
Copy link
Member

Hi,

Thanks for your help
I'm currently migrating all the adapters from @date-io to our repository in order to ease the major evolution we might want to do in the future.

Once this is done, we could probably try again to create a working JS Joda adapter.

@psigns
Copy link

psigns commented May 11, 2023

@flaviendelangle Is there an issue or PR tracking the migration of these adapters?

Our team also is using js-joda, so we would like to subscribe to get updates.

@flaviendelangle
Copy link
Member

#4703

You can track this one 👍

@oliviertassinari
Copy link
Member

(I have added the review request to remove the PR from https://tools-public.onrender.com/prod/pages/1t353h04)

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2024
@joshkel
Copy link
Contributor Author

joshkel commented Apr 28, 2024

I've updated my js-joda adapter for the current version of MUI-X.

If any users of js-joda are interested in giving it a try, I'd appreciate it. It works for my purposes (a controlled date picker using a js-joda LocalDate) and for the basic demo, but I haven't tested all of the combinations of MUI-X components and features with js-joda data types.

If the MUI-X team wants to include it, I'm happy to continue working on this PR. If not, I understand; I can see about creating a separate NPM package in that case.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 30, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] Re-export all date-io adapters from our packages
6 participants