[docs] Cleanup the doc pages of the community pickers #7339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
docs
These are the results for the performance tests:
|
flaviendelangle
commented
Dec 29, 2022
| @@ -6,7 +6,7 @@ import { Unstable_StaticNextDatePicker as StaticNextDatePicker } from '@mui/x-da | |||
| export default function StaticDatePickerDemo() { | |||
| return ( | |||
| <LocalizationProvider dateAdapter={AdapterDayjs}> | |||
| <StaticNextDatePicker displayStaticWrapperAs="desktop" /> | |||
There was a problem hiding this comment.
Now that we have dedicated pages for the view components, I think that the static demos should display the toolbar, otherwise the diff between the two components is hard to understand.
packages/x-date-pickers-pro/src/internal/hooks/useStaticRangePicker/useStaticRangePicker.tsx
Outdated
Show resolved
Hide resolved
flaviendelangle
force-pushed
the
communiy-pickers-doc-cleanup
branch
from
27acaa4
to
0c0edde
Compare
LukasTy
reviewed
Dec 30, 2022
packages/x-date-pickers-pro/src/internal/hooks/useStaticRangePicker/useStaticRangePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/internal/hooks/useStaticRangePicker/useStaticRangePicker.tsx
Outdated
Show resolved
Hide resolved
flaviendelangle
force-pushed
the
communiy-pickers-doc-cleanup
branch
from
4f2aabf
to
9d10de8
Compare
flaviendelangle
force-pushed
the
communiy-pickers-doc-cleanup
branch
from
9d10de8
to
f9b3d70
Compare
LukasTy
reviewed
Jan 3, 2023
There was a problem hiding this comment.
To me overall the new approach shown on date picker page seems like the most cohesive and if it were my decision—I'd go forth with updating other pages.
But we could also possibly wait/ask for @joserodolfofreitas opinion on this refactor/restructure. 🤔
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
flaviendelangle
force-pushed
the
communiy-pickers-doc-cleanup
branch
from
597d421
to
af4d293
Compare
LukasTy
reviewed
Jan 4, 2023
LukasTy
approved these changes
Jan 4, 2023
packages/x-date-pickers-pro/src/internal/hooks/useStaticRangePicker/useStaticRangePicker.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of small changes to unify the doc of the Date Picker, Time Picker and Date Time Picker.
I'll keep the Date Range Picker for later, as it needs a Date Range Calendar dedicated page.
The Date Picker page still have 2 demos I'd like to move to other pages (the helper text and the custom input one).
But I think this PR is big enough as it is.