Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Added support for time column type #5422

Draft
wants to merge 2 commits into
base: v6.x
Choose a base branch
from
Draft

[DataGrid] Added support for time column type #5422

wants to merge 2 commits into from
+694 −127

Conversation

Zenoo
Copy link
Contributor

@Zenoo Zenoo commented Jul 7, 2022 •
edited by m4theushw
Loading

Closes #5421

This PR should add support for the time column type.

This is a work in progress, I simply searched the whole repo for places where dateTime was mentioned and edited/added the equivalents for time.

@mui-bot
Copy link

mui-bot commented Jul 7, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 470 798.7 559.9 623.62 142.776
Sort 100k rows ms 531 1,069.5 672.2 768.88 187.822
Select 100k rows ms 204 304.9 280.2 269.36 34.652
Deselect 100k rows ms 123.2 198.1 186.9 178.1 28.011

Generated by 🚫 dangerJS against 7570af3

@cherniavskii cherniavskii self-requested a review July 8, 2022 09:59
@m4theushw m4theushw added the component: data grid This is the name of the generic UI component, not the React module! label Jul 11, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 15, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 15, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 24, 2022 •
edited
Loading

From what I recall, the time picker has 1/10 of the requests compared to a date picker in material-ui-pickers. Maybe this should only be a demo?

Also, I would expect a better UX from using an Autocomplete rather than the Time Picker to implement this. #4483 https://mui.com/material-ui/react-autocomplete/#disabled-options

@aaarichter
Copy link

@Zenoo it would be great to have your change. looking forward to it

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2022
@DanailH DanailH changed the base branch from master to next September 12, 2022 13:06
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 12, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 13, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@m4theushw
Copy link
Member

Hey, do you still want to push this forward?

@Zenoo
Copy link
Contributor Author

Zenoo commented Dec 12, 2022 •
edited
Loading

Sure, but it's been quite some time.
If you can point me to what needs to be done, I'd be happy to.

@alexfauquette alexfauquette mentioned this pull request Sep 19, 2023
Open
2 tasks
@MBilalShafi MBilalShafi changed the base branch from master to v6.x March 21, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Add native data grid time column type
6 participants
@Zenoo @mui-bot @oliviertassinari @aaarichter @m4theushw @MBilalShafi