Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Drop support for Node 10 #1499

Merged
merged 1 commit into from
Apr 29, 2021
Merged

[core] Drop support for Node 10 #1499

merged 1 commit into from
Apr 29, 2021

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Apr 26, 2021 •
edited by oliviertassinari
Loading

BREAKING CHANGE

  • [core] Increase the minimum Node.js version from 10.x to 12.x

Closes #1312

Also enables to upgrade @material-ui/monorepo and many other packages like in PRs #1484, #1478

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 26, 2021 •
edited
Loading

The same on the core side mui/material-ui#25306, you can check the diff to help if some of the steps are failing in the CI.

@oliviertassinari oliviertassinari added breaking change core Infrastructure work going on behind the scenes labels Apr 26, 2021
@ZeeshanTamboli
Copy link
Member Author

The same on the core side mui-org/material-ui#25306, you can check the diff to help if some of the steps are failing in the CI.

Yup referred it. That's why added node option in .codesandbox/ci.json config codesandbox/codesandbox-ci-ui#22 (comment)

@ZeeshanTamboli
Copy link
Member Author

Can this be reviewed?

@dtassone dtassone merged commit 535b23a into mui:master Apr 29, 2021
@ZeeshanTamboli ZeeshanTamboli deleted the issue/1312 branch April 29, 2021 14:50
@oliviertassinari oliviertassinari mentioned this pull request Jul 10, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtassone dtassone dtassone approved these changes

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees
No one assigned
Labels
breaking change core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] Upgrade min version of node.js from 10 to 12
3 participants
@ZeeshanTamboli @oliviertassinari @dtassone